Skip to content

fix Windows torch source marker#6380

Merged
liuruibin merged 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-windows-torch-marker
Jul 10, 2026
Merged

fix Windows torch source marker#6380
liuruibin merged 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-windows-torch-marker

Conversation

@zhonggang666

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Fixes the Windows torch uv source marker.

Closes #6368.

Summary of your change

Changes the Windows marker from sys_platform == 'win' to sys_platform == 'win32', which is the value used by Python packaging markers on Windows.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Validation:

  • git diff --check
  • packaging.markers.Marker("sys_platform == 'win32'").evaluate({'sys_platform': 'win32'}) returns True.

@zhonggang666 zhonggang666 force-pushed the codex/split-fix-windows-torch-marker branch from 746f9bf to d7da2d9 Compare July 9, 2026 09:27
@zhonggang666 zhonggang666 changed the title [codex] fix Windows torch source marker fix Windows torch source marker Jul 9, 2026
@zhonggang666 zhonggang666 marked this pull request as ready for review July 9, 2026 13:20
@liuruibin liuruibin merged commit 78d90e3 into 1Panel-dev:v2 Jul 10, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Windows torch source marker uses sys_platform == win instead of win32

2 participants