Add SCO re-onboarding step to ensure no authorized keys escape cleanup - #1120
Merged
Chr1st0ph3rTurn3r merged 1 commit intoAug 19, 2026
Merged
Conversation
There's a particular case where 1. SCO has completed and placed authorized keys 2. Salt onboarding has not been attempted In this case, the AP does not have any state for the asset. Cleanup does not attempt to remove the authorized keys when it hasn't seen that asset. The result is subsequent SCO attempts would repeatedly fail as already complete (authorized keys already exist). Explicit cleaning prevents this corner case possibility.
gregschrock
requested review from
Chr1st0ph3rTurn3r and
MichaelBaj
as code owners
August 19, 2026 13:21
MichaelBaj
approved these changes
Aug 19, 2026
Chr1st0ph3rTurn3r
approved these changes
Aug 19, 2026
Chr1st0ph3rTurn3r
deleted the
gschrock/sco-delete-auth-keys-during-reonboarding
branch
August 19, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a particular case where
In this case, the AP does not have any state for the asset. Cleanup does not attempt to remove the authorized keys when the AP hasn't seen that asset. The result is subsequent SCO attempts would repeatedly fail as already complete (which would be correct because authorized keys already exist).
Explicit cleaning prevents this partial onboarding corner case and ensures SCO can be rerun from the beginning.