Add sanitize_callback to validate palette checkbox input #290
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
Sidsector9
and removed request for
dkotter and
jeffpaul
Sidsector9
requested changes
Aug 13, 2025
| 'default' => false, | ||
| 'sanitize_callback' => function( $input ) { | ||
| // Accept only true, 'on', or 1 | ||
| if ( $input === 'on' || $input === true || $input === 1 || $input === '1' ) { |
Member
There was a problem hiding this comment.
Thanks for raising this fix @aditigodse10
I found an issue, that when you try to save the settings with the checkbox unchecked, the Invalid value for Most Used Palette setting. error is shown on top of the page. This is because $input is null when it is unchecked. Can you fix that?
Member
There was a problem hiding this comment.
@aditigodse10 checking in to see if you'll be able to updated based on the code review feedback above?
github-project-automation
bot
moved this from Code Review
to In Progress
in Open Source Practice
Member
|
@peterwilsoncc will probably need your help in getting this finished off/reviewed/merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sanitize_callback to the
tenup_isc_most_read_paletteoption to validate input before saving.✅ Accepts only true, 'on', 1, or '1'
❌ Rejects all invalid values
🛡️ Shows an admin error using
add_settings_error()when input is incorrectThis ensures secure, expected handling of the checkbox setting and follows WordPress sanitization best practices.