Replace substr and strpos with str_starts_with for better readability#216
Draft
Soean wants to merge 2 commits into
Draft
Replace substr and strpos with str_starts_with for better readability#216Soean wants to merge 2 commits into
Soean wants to merge 2 commits into
Conversation
Member
|
@Soean seeing this is in draft, so we'd normally hold off reviewing until it comes out of draft by also noting that Darin and I are almost fully focused until mid-April on the https://github.com/wordPress/ai plugin so it may be a while until we get back to this PR, so your patience is appreciated, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request refactors several string comparison operations to use the more readable and modern
str_starts_with()function instead of manualsubstrorstrposchecks. This improves code clarity and consistency when checking for specific string prefixes.Edit:
str_starts_withwas introduced with PHP 8.0 and polyfilled in WordPress 5.9The plugin minimum is:
So we need to increase the WordPress or PHP minimum to merge the PR.
Changelog Entry
Checklist: