model_specs: correct descriptions that contradict the code - #403
Closed
CryptVenture wants to merge 1 commit into
Closed
model_specs: correct descriptions that contradict the code#403CryptVenture wants to merge 1 commit into
CryptVenture wants to merge 1 commit into
Conversation
Description text only. No declared type, bound, default or required flag
changes, so no request that was accepted or rejected before changes state.
- dramabox: five descriptions claimed their default "comes from config.json".
dramabox/assets.cpp reads config.json for architecture only; the defaults
named in the spec are the engine's own, so the sentence pointed reviewers
at a file that does not carry them.
- fish_audio.reference_text: says it is required whenever the request carries
inline reference audio. fish_audio/session.cpp:255-258 throws
"<role> with inline reference audio requires reference_text option".
- outetts.reference_text: same, per outetts/session.cpp:695-698 and 722-728,
"OuteTTS voice cloning requires --reference-text".
Both reference_text options stay `required: false`: they are required only when
reference audio is present, and the schema's `required` is a plain bool with no
conditional form, so marking them required would break plain TTS with a
built-in voice.
CryptVenture
force-pushed
the
pr/spec-descriptions
branch
from
September 3, 2026 00:04
347e31d to
a0cc0c9
Compare
Contributor
Author
|
Closing for now to stay inside the 3-concurrent-PR policy (see the discussion on #422). Nothing is wrong with the change and CI is green on it; I will reopen it as review slots free. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #372 as requested. This PR is description text only; the strict contract fixes, the VoxCPM1 defaults, the ASR/aligner/codec declarations and the MiniMax declarations are separate PRs.
Nothing here changes a declared type, bound, default or required flag, so no request that was accepted or rejected before changes state.
The changes
dramaboxconfig.json"dramabox/assets.cppreadsconfig.jsonfor the architecture only; the values named are the engine's ownfish_audio.reference_textsrc/models/fish_audio/session.cpp:255-258throws"<role> with inline reference audio requires reference_text option"outetts.reference_textsrc/community_models/outetts/session.cpp:695-698and722-728throw"OuteTTS voice cloning requires --reference-text"Both
reference_textoptions stayrequired: falseon purpose: they are required only when reference audio is present, and the schema'srequiredis a plain bool with no conditional form, so marking them required would break plain TTS with a built-in voice. The description is the only place that distinction can currently live.Validation
Scope
Three spec files, 7 lines. The generated WebUI bundle (
webui/native/dist/index.html) is deliberately not included:catalog.tsinlinesmodel_specs/*.jsonat frontend build time and the bundle is not byte-reproducible, so regenerating it in each PR of this split would produce conflicts between them. Happy to send one bundle-regeneration PR once the series has landed.