feat: collation improvement at the tip of the chain#144
Open
alex-kulam wants to merge 1 commit into0xPolygon:release/3.2-developfrom
Open
feat: collation improvement at the tip of the chain#144alex-kulam wants to merge 1 commit into0xPolygon:release/3.2-developfrom
alex-kulam wants to merge 1 commit into0xPolygon:release/3.2-developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refactor in a prior commit restructured the worker-count assignment into initialCycle branches, accidentally leaving chain-tip mode (initialCycle=false) with only 1 collate/build worker instead of 4.
On high-throughput chains like Polygon PoS, a single collation worker cannot keep pace with block execution. Domain steps fall behind, MDBX accumulates unflushed state faster than it can be collated, and
ReclaimableSpacegrows unbounded.Fix: SetCollateAndBuildWorkers and SetMergeWorkers are now set unconditionally (outside the initialCycle branch), restoring 4 collate and 2 merge workers in both initial-sync and chain-tip modes.
SetCompressWorkers retains the initialCycle distinction (full CPU during initial sync, capped at 2 at chain tip to avoid background I/O contention).