feat: add tracing support for StateSyncTx#2062
Closed
milando12 wants to merge 36 commits into0xPolygon:developfrom
Closed
feat: add tracing support for StateSyncTx#2062milando12 wants to merge 36 commits into0xPolygon:developfrom
milando12 wants to merge 36 commits into0xPolygon:developfrom
Conversation
maoueh
reviewed
Feb 18, 2026
consensus/bor/bor.go
Outdated
| start := time.Now() | ||
| cx := statefull.ChainContext{Chain: chain, Bor: c} | ||
|
|
||
| // Start tracing StateSyncTx (if present in the block body) |
Contributor
There was a problem hiding this comment.
I think we might have integration tests locally (we maintain our own Polygon Live Tracing branch for now).
I'll check if I could add that on top of your PR.
Author
There was a problem hiding this comment.
That sounds great. Feel free to add them on top of this PR whenever you're ready.
- Introduced `vm.Config` to multiple functions for customizable VM tracing. - Added tracer configuration flags (`vmtrace` and `vmtrace.jsonconfig`) to streamline monitoring during blockchain synchronization. - Updated GenesisContract and spanner interfaces for trace integration. - Integrated tracing hooks for StateSyncTx events.
Remove the 4 [DEBUG] log lines that were added during development to diagnose StateSyncTx tracing issues.
When Finalize is called, the chain parameter can be a *core.HeaderChain (not just *core.BlockChain). Without this change, the tracer in vmCfg is nil during finalization, so StateSyncTx tracing hooks never fire. - Add vmConfig field and GetVMConfig() method to HeaderChain - Set hc.vmConfig in NewBlockChain after creating the HeaderChain - Add else-if branch in Finalize and FinalizeAndAssemble to extract VM config from HeaderChain
The Process function creates a tracingStateDB wrapper for tracing but was passing the unwrapped statedb to Finalize, causing the tracer to miss StateSyncTx state changes.
milando12
force-pushed
the
md/feat-tracer
branch
from
da6e677 to
2b43baf
Compare
Expand the `CommitState` method signature to include the `vm.Config` parameter, enabling proper VM tracing integration and configuration.
EVM struct has a comment saying never reuse
Add support for preconf and private transaction APIs - Introduce new flags and APIs for preconf and private transactions. - Add methods for transaction preconfirmation and private transaction handling in backends and API layers. - Update transaction submission logic to support preconf/private paths. - Include tests for all new functionalities and edge cases.
- Update method signatures to include `vm.Config`, enabling better VM tracing and configuration integration in testing and state processing logic.
…lper function - Consolidate duplicate code for retrieving `vm.Config` from `ChainHeaderReader`. - Simplify `Finalize` method by utilizing the new helper.
The state processor now passes the traced (hooked) StateDB to the consensus engine's Finalize method, so live tracers can observe balance changes from block reward distribution. This is the correct behavior — previously, Finalize received the raw StateDB, making block rewards invisible to live tracers like the supply tracer. Update TestSupplyRewards and TestSupplyEip1559Burn to include the expected ethash block reward (2 ETH) in their assertions, matching the new traced output.
Member
|
@claude - review this PR. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Member
It won't be able to review this PR is from a fork, and hence it doesn't have perms to fetch the branch. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
marcello33
reviewed
Mar 9, 2026
marcello33
reviewed
Mar 9, 2026
Collaborator
|
Can we ad integration tests that verify the trace output for a block containing a StateSyncTx? |
1 task
|
18 tasks
Member
|
Closing this in favor of #2172. Some tests won't work in this PR as it's created from a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding tracing support for
StateSyncTx.Changes
Checklist
Cross repository changes
Testing
Manual tests
Ran the Node with this code for few days - no problems showed up and I verified that
StateSyncTxtrace that we get is correct.