Skip to content

docs(board): 纠偏「负载性 flake 假绿」的误判,指向 AAV-1330 真因 - #772

Merged
0xPabloLI merged 1 commit into
devfrom
lovable
Oct 10, 2026
Merged

0xPabloLI merged 1 commit into
devfrom
lovable

Conversation

@0xPabloLI

Copy link
Copy Markdown
Owner

只改 SESSION-BOARD.md 一行:撤掉我上一轮写错的「vitest 报 Errors 却 exit 0 ⇒ 本地门假绿」。

  • 实测证据:隔离复现(临时 root + 最小 config,用 Promise.reject() 造 unhandled error)得到 Test Files 1 passed / Errors 1 error 配 rc=1 ⇒ runner 清白,vitest 5.0.3 会把 unhandled error 计入退出码。
  • 我读错的原因:${PIPESTATUS[0]} 是 bash 语法,本环境是 zsh(要 $pipestatus[1]),当时取到的是管道尾端 tail 的退出码。
  • 真洞在 hook,已修并已进 dev:52e5ace1(AAV-1330,随 fix(gate): pre-push 假绿(AAV-1330) + sync 工作流 auto-merge 的 GraphQL 字段错 #771)。看板这一行现在指向订正,避免下个 session 去修一个不存在的 bug。

本地门:npm test 4098 单测 + scripts 193/193;pre-push 全门 PUSH_RC=0(e2e 64 passed / 5.0m、osv No issues found、semgrep/knip/dup 全跑)。

板上「vitest 报 Errors 却 exit 0 ⇒ 本地门假绿」这条是我读退出码读错了(bash 的 PIPESTATUS 在 zsh 下取到管道尾端的 0)。隔离复现证明 vitest 5.0.3 会因 unhandled error 返回 rc=1;真正的假绿洞在 .husky/pre-push 的 ci:remote && e2e 那一行,已由 52e5ace 修掉并进 dev(#771)。订正同时记下两条方法教训:取退出码要先落文件再取 0;指认某个工具假绿之前先做隔离复现。
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
aave-protocol-explorer Ready Ready Preview Oct 10, 2026 11:47am UTC

@linear-code

linear-code Bot commented Oct 10, 2026

Copy link
Copy Markdown

AAV-1330

@factory-droid

factory-droid Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Droid finished @0xPabloLI's task —— View job


Validated 0 candidate findings for PR #772 (candidates file contained an empty comments array). Independently reviewed the full diff: a docs-only, single-line correction in SESSION-BOARD.md that retracts an incorrect vitest false-green claim and points to the real hook fix (52e5ace, AAV-1330). No code or security changes are involved; no review findings to report.

0 inline comments posted

@0xPabloLI
0xPabloLI merged commit e3481e8 into dev Oct 10, 2026
45 checks passed

This branch was successfully deployed

1 active deployment
Preview — 2ab2253d Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant