Tracking migration work for lifted STARK#881
Merged
Conversation
Al-Kindi-0
changed the title
adr1anh
force-pushed
the
tracking-migration-work
branch
from
f931d84 to
59c0c9c
Compare
Update all Plonky3 dependencies across the workspace to rev 7ca1cdff (matching the revision used by p3-miden at 5d0201f). Pin p3-miden crates to rev 5d0201f from Nashtare/p3-miden (PR #34 branch). Remove AirWithPeriodicColumns re-export as it was merged into LiftedAir. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update upstream Plonky3 from rev 7ca1cdff to 4341702b and p3-miden from 5d0201f to 0cf9192. Consolidate individual p3-miden crates (lifted-air, lifted-fri, lmcs, stateful-hasher, transcript) into the unified p3-miden-lifted-stark re-export, simplifying the stark module. Also re-export new field traits (Algebra, BoundedPowers, Powers) and replace direct p3_field imports with crate::field paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump p3-miden-lifted-stark to rev 0aa0706, which adds a debug constraint checker for lifted AIRs. Re-export the new `debug` module from `stark` so consumers can use it directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Plonky3: 4341702b → 69270b50 (adds CanFinalizeDigest trait) - p3-miden: 0aa0706 → d6a9360 (proof types in proof module, CanFinalizeDigest integration, no top-level re-exports) - Re-export proof and debug modules from stark - Add CanFinalizeDigest to stark::challenger re-exports - Remove coset from stark re-exports Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Switch all Plonky3 deps from git rev to published 0.5.0 crates - Point p3-miden at 0xMiden/p3-miden main branch (merged PR #34) - Add proof module and CanFinalizeDigest to stark re-exports - Remove coset from stark re-exports - Update deny.toml for new git source and rand duplicate tree Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adr1anh
force-pushed
the
tracking-migration-work
branch
from
d8a4c27 to
7cc3304
Compare
Contributor
|
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bobbinth
requested review from
adr1anh,
bobbinth and
huitseeker
and removed request for
adr1anh,
bobbinth and
huitseeker
Contributor
|
I think there is a small merge conflict remaining. @Al-Kindi-0, @adr1anh, @huitseeker - could you let me know when this is good to merge? |
Collaborator
Author
|
Seems good from my end, though we should get the VM matching PR rebased, approved, and ready before merging this one, in my opinion. |
bobbinth
approved these changes
Mar 11, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one question inline. Also:
- Let's add a changelog entry (especially since this is a breaking change).
- Would be good to update the STARK section in the main readme (i.e., to mentioned Lifted STARK/FRI).
we should get the VM matching PR rebased, approved, and ready before merging this one
This would be this PR, right 0xMiden/miden-vm#2783? Who is working on this?
Update the STARK section in README to describe the Lifted STARK proving system from p3-miden built on top of the Plonky3 framework. Add a CHANGELOG entry for the Plonky3 0.5.0 upgrade and p3-miden-lifted-stark consolidation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
Yes, @adr1anh already rebased and merged the lifted STARK PR github.com/0xMiden/miden-vm/pull/2798 |
huitseeker
reviewed
Mar 11, 2026
adr1anh
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
p3-midenmigrationChecklist before requesting a review
nextaccording to naming convention.