Repository navigation
WebSocket: disconnect() sends pending subscribe and unsubscribe calls - #23
Merged
Merged
Conversation
…nnection sends no longer log task errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscribe()andunsubscribe()send their frames from background tasks. Two problems:disconnect()closed the socket without waiting for them. Anunsubscribe()followed bydisconnect()could therefore fail against the closed connection and logTask exception was never retrieved.Changes:
disconnect()flushes them first, waiting up to 2 seconds.on_errorhandler.Tested:
tests/test_websocket_sends.py: three tests. All three fail onmasterand pass here.master.wss://stream.0xarchive.io/ws: three subscribe, unsubscribe anddisconnect()cycles, with no loop errors and no unsent frames left.Part of the unreleased 1.13.0 (CHANGELOG "Fixed").