Skip to content

fix(client): reset client request stream on drop - #5

Open
0x676e67 wants to merge 2 commits into
mainfrom
fix-request-stream-drop-reset
Open

fix(client): reset client request stream on drop#5
0x676e67 wants to merge 2 commits into
mainfrom
fix-request-stream-drop-reset

Conversation

@0x676e67

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automatic stream cancellation and resetting when a RequestStream is dropped before completion. This is implemented via a new AbortOnDrop wrapper around the underlying FrameStream that triggers a reset or stop-sending signal on drop unless disarmed. The client-side connection enables this behavior, while the server-side disables it. Additionally, the quinn dependency in h3-quinn is updated to version 0.11, and a new integration test is added to verify that dropping a client request stream successfully cancels the request on the server. There are no review comments, so no further feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@0x676e67
0x676e67 changed the base branch from main to qpack-decoder June 17, 2026 11:24
@0x676e67
0x676e67 changed the base branch from qpack-decoder to main June 17, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant