Skip to content

Limit bootstrap secret downloads and clarify Cloudflare guidance - #11

Draft
edgepillar wants to merge 1 commit into
0x3639:mainfrom
edgepillar:security/cloudflare-followup
Draft

edgepillar wants to merge 1 commit into
0x3639:mainfrom
edgepillar:security/cloudflare-followup

Conversation

@edgepillar

Copy link
Copy Markdown

Summary

  • Bound authenticated bootstrap secret downloads per node token and return 429 with Retry-After after the quota is reached. Existing bearer authentication, node-type checks, and other bootstrap routes remain unchanged.
  • Correct the dashboard/API guidance for customer-uploaded Authenticated Origin Pulls certificates.
  • Scope the proposed CF-Connecting-IP follow-up to client-IP attribution and rate limiting on ordinary proxied requests, not identity or authentication.

Validation

  • npm run typecheck
  • npm run build
  • npm test (94 passed, 1 skipped because a Go toolchain is unavailable)
  • Local HTTP regression coverage for unauthorized and wrong-type requests, per-token quota isolation, both pillar and seed secret routes, 429, and Retry-After.

Scope

This follows up the remaining review comments on #9. The changes were tested locally. No Cloudflare settings or origin deployment were changed, and no live origin behavior was verified.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant