Repository navigation
fix: pin official Magisk to avbroot compatibility baseline - #106
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop floating rooted builds to the highest Magisk tag. Keep official
topjohnwu/Magisk, but pin the default compatibility baseline tov30.7until a newer version is deliberately validated on-device.Upstream basis
chenxiaolong/avbroot3.34.0 explicitly added Magisk 31000 support, and ModOS uses avbroot 3.34.1, so v31 is not rejected as an unknown patch format.Direct install.Changes
MAGISK_VERSION, defaulting tov30.7.topjohnwu/Magiskas the source.This deliberately treats v30.7 as the production baseline and v31+ as an explicit compatibility test until runtime root is confirmed on shiba.