Skip to content

fix: restore official Magisk as the rooted build source - #105

Merged
0cwa merged 8 commits into
mainfrom
fix/official-magisk-default-20260921
Sep 21, 2026
Merged

0cwa merged 8 commits into
mainfrom
fix/official-magisk-default-20260921

Conversation

@0cwa

@0cwa 0cwa commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Summary

Restore official topjohnwu/Magisk as the default Magisk source for rooted ModOS builds.

The pixincreate Magisk fork was previously made the default to carry GrapheneOS-specific Zygisk compatibility. ModOS no longer needs to couple the OTA build to that fork when Zygisk compatibility is provided separately (for example through Zygisk Next).

Changes

  • Change the typed MAGISK[REPOSITORY] default from pixincreate/Magisk to topjohnwu/Magisk.
  • Update the env.toml example and root documentation to make alternate Magisk forks opt-in.
  • Document that Zygisk Next is managed separately from the OTA build.
  • Include the Magisk repository in the rooted module-selection fingerprint.
    • rootless fingerprints remain independent of Magisk source;
    • rooted builds from different Magisk repositories can no longer collide when they use the same version tag.
  • Add regression tests for the official default and repository-sensitive rooted identity.

The existing Magisk version-resolution behavior is unchanged: the build selects the highest repository tag. For topjohnwu/Magisk that currently resolves to v31.0.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2f445456-9e36-421e-a4a8-752f9ba54279


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@0cwa
0cwa merged commit 9d7a047 into main Sep 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant