Repository navigation
fix: restore official Magisk as the rooted build source - #105
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore official
topjohnwu/Magiskas the default Magisk source for rooted ModOS builds.The pixincreate Magisk fork was previously made the default to carry GrapheneOS-specific Zygisk compatibility. ModOS no longer needs to couple the OTA build to that fork when Zygisk compatibility is provided separately (for example through Zygisk Next).
Changes
MAGISK[REPOSITORY]default frompixincreate/Magisktotopjohnwu/Magisk.env.tomlexample and root documentation to make alternate Magisk forks opt-in.The existing Magisk version-resolution behavior is unchanged: the build selects the highest repository tag. For
topjohnwu/Magiskthat currently resolves tov31.0.