Open
Conversation
This adds support for publishing game lists, rating lists and the leader board via PubSub. With matching support in pyrogenesis this will improve the performance and efficiency of the lobby, as the bots then don't have to manually send updates to each connected client, but the clients subscribe to the PubSub nodes and the XMPP server takes care of deliverying updates instead. The previous behavior of sending stanzas with updates to every connected client is still available, but can be disabled with the `--disable-legacy-lists` command line flag. The performance benefits of PubSub do only materialize when the legacy behavior is disabled.
The disco query to list existing PubSub nodes on startup was missing for EcheLOn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for publishing game lists, rating lists and the leader board via PubSub. With matching support in pyrogenesis this will improve the performance and efficiency of the lobby, as the bots then don't have to manually send updates to each connected client, but the clients subscribe to the PubSub nodes and the XMPP server takes care of deliverying updates instead.
The previous behavior of sending stanzas with updates to every connected client is still available, but can be disabled with the
--disable-legacy-listscommand line flag. The performance benefits of PubSub do only materialize when the legacy behavior is disabled.