Fix canvas owner liveness across concurrent sessions - #159
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc712bcd-b101-45f2-9d6b-b278fd884ce9
There was a problem hiding this comment.
Pull request overview
Extends bridge liveness tracking so concurrently active sessions keep their AgentDocs online independently.
Changes:
- Adds and populates all live session IDs per worktree.
- Uses the full live-session set for document status and session-launch visibility.
- Updates specifications and regression tests.
Show a summary per file
| File | Description |
|---|---|
src/Shared/Types.fs |
Adds LiveSessionIds and lookup helper. |
src/Server/SessionBridge.fs |
Aggregates live identified sessions. |
src/Client/CanvasPane.fs |
Checks document owners against all live sessions. |
src/Tests/SessionBridgeTests.fs |
Covers stale-session liveness output. |
src/Tests/CanvasBridgeTests.fs |
Covers concurrent non-freshest owners. |
docs/spec/canvas-pane.md |
Documents multi-session liveness behavior. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix
BridgeLiveness.LiveSessionIdscontaining every identified session still within the liveness TTL.SessionIdfor aggregate status and SystemView fallback routing.Tests
dotnet test src\Tests\Tests.fsproj --filter "FullyQualifiedName~CanvasBridgeTests|FullyQualifiedName~SessionBridgeTests"— 66 passednpm run build