Skip to content
This repository was archived by the owner on Nov 8, 2026. It is now read-only.

chore: retire the site, merged into 0-draft/aws-connectivity - #25

Merged
kanywst merged 3 commits into
mainfrom
chore/retire-merged-into-aws-connectivity
Nov 8, 2026
Merged

kanywst merged 3 commits into
mainfrom
chore/retire-merged-into-aws-connectivity

Conversation

@kanywst

@kanywst kanywst commented Nov 8, 2026

Copy link
Copy Markdown
Member

This site was merged into 0-draft/aws-connectivity as its Direct Connect deep dive (0-draft/aws-connectivity#16). The repo stays up for a month of notice and will be archived on or after 2026-12-08.

  • README (EN/JA): merge notice at the top, site link points at https://0-draft.github.io/aws-connectivity/direct-connect/, sibling-site link updated.
  • deploy.yml: Pages now publishes only redirect/ (index.html and 404.html), which forwards to the new page and keeps ?lang= and the #section, so old deep links such as /cross-connect/?lang=ja#routing land on the same stop. Meta refresh and a plain link cover no-JS readers.
  • freshness.yml removed: the monthly DX checklist now lives in aws-connectivity's freshness workflow.

The app code stays as is for history; CI still runs on it.

Verification (local)

  • npm run format:check, npm run lint:md, actionlint — pass

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 23a55e2b-9521-4f34-8110-8f0a7d0f6b5b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread redirect/index.html Outdated
Comment on lines +11 to +13
<meta name="robots" content="noindex" />
<meta
http-equiv="refresh"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zero-delay meta refresh sits before the script and carries no ?lang= or #section. If the browser acts on it first, the script's location.replace is moot and old deep links such as /cross-connect/?lang=ja#routing land on the new site's top. That would contradict the PR's claim that they "land on the same stop". Put the refresh in <noscript>, or drop it, so the JS path is the only one with JS on.

The no-JS fallback links in the body also drop #section. The Japanese link hard-codes ?lang=ja regardless of the incoming URL.

The PR also asserts the new page keeps the same section ids (#routing and so on). Nothing in this repo verifies that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: the meta refresh is now inside , so with JS on the script is the only redirect and it keeps ?lang= and #section. The JA fallback link pointing at ?lang=ja is deliberate (Japanese text, Japanese page). On the ids: the deep dive's sections were copied as-is into aws-connectivity (its src/features/direct-connect/content/nav.ts is this repo's nav.ts), and its e2e checks that every in-page #id resolves.

@claude

claude Bot commented Nov 8, 2026

Copy link
Copy Markdown

Retirement/redirect PR. There is no CLAUDE.md or CONTRIBUTING.md here. The EN and JA README notices match in content and dates (2026-11-08; archive on or after 2026-12-08). Workflows keep pinned actions and least privilege.

Findings:

  • redirect/index.html:11-13 (and the identical redirect/404.html): the meta refresh carries no ?lang= or #section and can pre-empt the script, so the "same stop" deep-link claim may not hold. Wrap it in <noscript>.
  • Unverified: that the new site uses the same section ids as the old one. Nothing in this repo checks it.
  • redirect/404.html is a byte-identical copy of index.html. That works for Pages, but the two will drift if one is edited.

@claude

claude Bot commented Nov 8, 2026

Copy link
Copy Markdown

The redirect pages, EN/JA README text and dates are consistent, and the actions stay pinned with least-privilege permissions. One nit: the comment in deploy.yml (line 40) says the build job runs third-party install scripts, but it no longer installs anything.

@kanywst
kanywst merged commit 04a86da into main Nov 8, 2026
15 checks passed
@kanywst
kanywst deleted the chore/retire-merged-into-aws-connectivity branch November 8, 2026 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant