Repository navigation
chore: retire the site, merged into 0-draft/aws-connectivity - #25
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
| <meta name="robots" content="noindex" /> | ||
| <meta | ||
| http-equiv="refresh" |
There was a problem hiding this comment.
The zero-delay meta refresh sits before the script and carries no ?lang= or #section. If the browser acts on it first, the script's location.replace is moot and old deep links such as /cross-connect/?lang=ja#routing land on the new site's top. That would contradict the PR's claim that they "land on the same stop". Put the refresh in <noscript>, or drop it, so the JS path is the only one with JS on.
The no-JS fallback links in the body also drop #section. The Japanese link hard-codes ?lang=ja regardless of the incoming URL.
The PR also asserts the new page keeps the same section ids (#routing and so on). Nothing in this repo verifies that.
There was a problem hiding this comment.
Fixed: the meta refresh is now inside , so with JS on the script is the only redirect and it keeps ?lang= and #section. The JA fallback link pointing at ?lang=ja is deliberate (Japanese text, Japanese page). On the ids: the deep dive's sections were copied as-is into aws-connectivity (its src/features/direct-connect/content/nav.ts is this repo's nav.ts), and its e2e checks that every in-page #id resolves.
|
Retirement/redirect PR. There is no CLAUDE.md or CONTRIBUTING.md here. The EN and JA README notices match in content and dates (2026-11-08; archive on or after 2026-12-08). Workflows keep pinned actions and least privilege. Findings:
|
|
The redirect pages, EN/JA README text and dates are consistent, and the actions stay pinned with least-privilege permissions. One nit: the comment in |
This site was merged into 0-draft/aws-connectivity as its Direct Connect deep dive (0-draft/aws-connectivity#16). The repo stays up for a month of notice and will be archived on or after 2026-12-08.
deploy.yml: Pages now publishes onlyredirect/(index.htmland404.html), which forwards to the new page and keeps?lang=and the#section, so old deep links such as/cross-connect/?lang=ja#routingland on the same stop. Meta refresh and a plain link cover no-JS readers.freshness.ymlremoved: the monthly DX checklist now lives in aws-connectivity's freshness workflow.The app code stays as is for history; CI still runs on it.
Verification (local)
npm run format:check,npm run lint:md,actionlint— pass