Repository navigation
fix(endpoints): scope the cross-partition route to the four documented partitions - #24
Merged
Merged
Conversation
…d partitions The non-commercial branch also covers ISO partitions, where AWS does not document cross-partition federation. Missed review comment on #23.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
No findings: the EN and JA text in decide.ts agree, and the four partitions named match docs/07-timeline.md:88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23 (a review comment there was missed before merging). The decision guide's non-commercial branch also covers ISO partitions, but cross-partition federation is documented only for
aws,aws-cn,aws-us-govandaws-eusc(IAM User Guide). The sentence now names those four, in EN and JA.Verification: Prettier, tsc, ESLint and Vitest (284 tests) pass locally.