Skip to content

fix(deps): patch transitive minimatch, re2js and zod - #18

Merged
kanywst merged 2 commits into
mainfrom
fix/transitive-security-overrides
Nov 8, 2026
Merged

kanywst merged 2 commits into
mainfrom
fix/transitive-security-overrides

Conversation

@kanywst

@kanywst kanywst commented Nov 8, 2026

Copy link
Copy Markdown
Member

Clears the two open Dependabot alerts, which Dependabot's security updates could not fix because no parent release takes the patched versions yet.

  • minimatch (GHSA-g3hv-75wg-m249, medium, patched in 11.0.1): pulled in at 10.2.6 by eslint, @eslint/config-array and @typescript-eslint/typescript-estree, whose latest releases still require ^10. Overridden to 11.0.5.
  • re2js (high, patched in 2.8.7): pulled in at 2.8.6 by markdownlint 0.42.0, which markdownlint-cli2 0.24.0 (latest) pins exactly. Overridden to 2.9.1, the version markdownlint 0.42.1 itself uses.
  • zod (GHSA-mrhx-c7xc-m3w5, high, no alert yet): npm audit also flagged zod 4.6.5 under eslint-plugin-react-hooks; npm audit fix moves the lockfile to 4.6.7 within the existing range.

The overrides can be dropped once eslint/typescript-eslint and markdownlint-cli2 ship releases on the patched versions.

Verification: npm ci && npm run check passes (typecheck, ESLint on minimatch 11, Prettier, markdownlint on re2js 2.9.1, 284 tests, build); npm audit reports 0 vulnerabilities.

minimatch <11.0.1 (GHSA-g3hv-75wg-m249) comes in through eslint and
typescript-eslint, whose latest releases still ask for ^10; re2js <2.8.7 comes
in through markdownlint 0.42.0, which markdownlint-cli2 0.24.0 pins exactly.
Neither parent has a fixed release, so pin the patched versions with
overrides.
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad434f20-9da4-4f29-9bfe-fca1f04d011c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread package.json
"smol-toml": "1.9.0",
"katex": "0.18.10"
"katex": "0.18.10",
"minimatch": "11.0.5",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This override forces minimatch 11 (a new major) onto every consumer, including eslint (^10.2.5), @eslint/config-array (^10.2.4) and @typescript-eslint/typescript-estree (^10.2.2). The lockfile still records those ^10 ranges, so the install is outside what each package declares it supports. It also pulls in a new transitive dependency, @isaacs/nonrecursive-glob-match. CI covers lint and build, but it won't show a glob-semantics change that only affects some ignore patterns. The commit message cites no advisory for minimatch, so please link the advisory and the first patched version. If a patched 10.x exists, pin that instead of jumping a major.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no patched 10.x: GHSA-g3hv-75wg-m249 covers minimatch >=7.0.0 <11.0.1, the first patched version is 11.0.1, and the latest 10.x is the vulnerable 10.2.6. eslint, @eslint/config-array and typescript-estree have no release on ^11 yet, so the override is the only way to clear it. The PR body names the advisory and patched version. Glob semantics: eslint's own ignore/config matching and markdownlint-cli2's globs run in CI (lint and lint:md over the whole repo) and produce the same results as on main. The override is dev-only and should be dropped once eslint and typescript-eslint move to ^11.

@claude

claude Bot commented Nov 8, 2026

Copy link
Copy Markdown

Dependency-only change (package.json overrides and lockfile): zod 4.6.7, minimatch 11.0.5, re2js 2.9.1. No docs, EN/JA content or workflows are touched.

One finding, posted inline on package.json:60: the minimatch override forces a new major (11) onto eslint, @eslint/config-array and typescript-estree, which all declare ^10. Please link the advisory and prefer a patched 10.x if one exists.

I could not check against the npm registry that minimatch 11.0.5 and re2js 2.9.1 exist or which advisories they fix. The Node engines they require (20+ and 22+) are compatible with the repo's Node >=24 requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant