From 4890626c794e006b3dbbfd4c2719d37995cc9c94 Mon Sep 17 00:00:00 2001
From: Yuri Sibirski <yuri@horizenlabs.io>
Date: Mon, 6 Jul 2026 12:55:29 -0400
Subject: [PATCH] ci: pass VERSION_STR to publish job and fix Slack Docker tag

The release workflow computed VERSION_STR in check_release_requirements.sh
but never exposed it as a job output or forwarded it to the publish job, so
publish-docker-image.sh saw an empty tag and failed with "invalid reference
format" (e.g. vflow-node: on the v2.0.0-rc1 release).

Expose VERSION_STR as a check-requirements output and pass it into the
publish step, mirroring the zkVerify workflow. Also switch the Slack Docker
Hub tag link and docker pull command from github.ref_name (v-prefixed) to the
v-stripped version-str, matching the actual pushed image tag.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .github/workflows/CI-release.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/CI-release.yml b/.github/workflows/CI-release.yml
index 9b35f49..25160d5 100644
--- a/.github/workflows/CI-release.yml
+++ b/.github/workflows/CI-release.yml
@@ -38,6 +38,7 @@ jobs:
       is-a-prod-release: ${{ steps.check-requirements.outputs.PROD_RELEASE }}
       is-a-rc-release: ${{ steps.check-requirements.outputs.RC_RELEASE }}
       is-a-test-release: ${{ steps.check-requirements.outputs.TEST_RELEASE }}
+      version-str: ${{ steps.check-requirements.outputs.VERSION_STR }}
     steps:
       - name: Git checkout
         uses: actions/checkout@v4
@@ -57,6 +58,7 @@ jobs:
           echo "PROD_RELEASE=${PROD_RELEASE}" >> "${GITHUB_OUTPUT}"
           echo "RC_RELEASE=${RC_RELEASE}" >> "${GITHUB_OUTPUT}"
           echo "TEST_RELEASE=${TEST_RELEASE}" >> "${GITHUB_OUTPUT}"
+          echo "VERSION_STR=${VERSION_STR}" >> "${GITHUB_OUTPUT}"
 
   build-docker:
     runs-on: warp-ubuntu-latest-x64-8x
@@ -104,6 +106,7 @@ jobs:
           PROD_RELEASE: ${{ needs.check-requirements.outputs.is-a-prod-release }}
           RC_RELEASE: ${{ needs.check-requirements.outputs.is-a-rc-release }}
           TEST_RELEASE: ${{ needs.check-requirements.outputs.is-a-test-release }}
+          VERSION_STR: ${{ needs.check-requirements.outputs.version-str }}
         shell: bash
         run: |
           "${GITHUB_WORKSPACE}/ci/publish-docker-image.sh" --image-artifact ${{ needs.build-docker.outputs.artifact_name }}
@@ -162,7 +165,7 @@ jobs:
                   "fields": [
                     {
                       "type": "mrkdwn",
-                      "text": "*Docker Image Tag:*  <https://hub.docker.com/r/${{ env.DOCKER_HUB_ORG }}/${{ env.DOCKER_IMAGE_BUILD_NAME }}/tags?page=1&name=${{ github.ref_name }}| ${{ github.ref_name }}>\n"
+                      "text": "*Docker Image Tag:*  <https://hub.docker.com/r/${{ env.DOCKER_HUB_ORG }}/${{ env.DOCKER_IMAGE_BUILD_NAME }}/tags?page=1&name=${{ needs.check-requirements.outputs.version-str }}| ${{ needs.check-requirements.outputs.version-str }}>\n"
                     },
                     {
                       "type": "mrkdwn",
@@ -174,7 +177,7 @@ jobs:
                   "type": "section",
                   "text": {
                     "type": "mrkdwn",
-                    "text": "```docker pull ${{ env.DOCKER_HUB_ORG }}/${{ env.DOCKER_IMAGE_BUILD_NAME }}:${{ github.ref_name }}```"
+                    "text": "```docker pull ${{ env.DOCKER_HUB_ORG }}/${{ env.DOCKER_IMAGE_BUILD_NAME }}:${{ needs.check-requirements.outputs.version-str }}```"
                   }
                 }
               ]