From fa336ff0d079bffb08596fe9257f54d759e8ee8d Mon Sep 17 00:00:00 2001 From: KirillKurdyukov Date: Tue, 20 Oct 2026 01:17:05 +0300 Subject: [PATCH 1/2] Add Topic compression and processing duration histograms --- .../tech/ydb/topic/read/impl/BatchMeta.java | 5 ++++ .../tech/ydb/topic/read/impl/MessageImpl.java | 4 +++ .../ydb/topic/read/impl/ReadPartition.java | 3 +- .../topic/read/impl/ReadPartitionDecoder.java | 12 ++++++++ .../ydb/topic/read/impl/ReaderMetrics.java | 29 +++++++++++++++++++ .../ydb/topic/write/impl/WriterMetrics.java | 29 +++++++++++++++++++ .../ydb/topic/write/impl/WriterQueue.java | 18 ++++++++++-- 7 files changed, 96 insertions(+), 4 deletions(-) diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/BatchMeta.java b/topic/src/main/java/tech/ydb/topic/read/impl/BatchMeta.java index ecc8a3a11..0a37315d4 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/BatchMeta.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/BatchMeta.java @@ -14,6 +14,7 @@ public class BatchMeta { private final Map writeSessionMeta; private final int codec; private final Instant writtenAt; + private final long receivedAt = System.nanoTime(); public BatchMeta(YdbTopic.StreamReadMessage.ReadResponse.Batch batch) { this.producerId = batch.getProducerId(); @@ -22,6 +23,10 @@ public BatchMeta(YdbTopic.StreamReadMessage.ReadResponse.Batch batch) { this.writtenAt = ProtobufUtils.protoToInstant(batch.getWrittenAt()); } + long getReceivedAt() { + return receivedAt; + } + public String getProducerId() { return producerId; } diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/MessageImpl.java b/topic/src/main/java/tech/ydb/topic/read/impl/MessageImpl.java index 0fb94e9d6..d0b827092 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/MessageImpl.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/MessageImpl.java @@ -48,6 +48,10 @@ public MessageImpl(PartitionSession session, MessageCommitter committer, BatchMe public abstract boolean isReady(); + long getReceivedAt() { + return batchMeta.getReceivedAt(); + } + @Override public long getOffset() { return offset; diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartition.java b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartition.java index 88909462c..e93007762 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartition.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartition.java @@ -75,7 +75,8 @@ private enum State { this.controlExecutor = config.getControlExecutor(); this.committer = new ReadPartitionCommitter(traceID, session, partition, lastCommittedOffset); - this.decoder = new ReadPartitionDecoder(traceID, sessionDecoder, partition, committer, this::sendDataToReaders); + this.decoder = new ReadPartitionDecoder(traceID, sessionDecoder, partition, committer, + this::sendDataToReaders, metrics); this.queue = new ReadPartitionQueue(traceID, decoder, config.getMaxBatchSize(), lastCommittedOffset); logger.info("[{}] started for {}", traceID, partition); diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java index b7234a42b..bdf60891d 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java @@ -12,6 +12,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import tech.ydb.core.metrics.Meter; import tech.ydb.proto.topic.YdbTopic; import tech.ydb.topic.description.Codec; import tech.ydb.topic.description.CodecRegistry; @@ -31,6 +32,7 @@ class ReadPartitionDecoder { private final PartitionSession partition; private final MessageCommitter committer; private final MessageDecoder decoder; + private final ReaderMetrics metrics; private final Runnable readyHandler; private final AtomicLong allocatedTotal = new AtomicLong(0); @@ -39,8 +41,14 @@ class ReadPartitionDecoder { ReadPartitionDecoder(String traceId, MessageDecoder decoder, PartitionSession partition, MessageCommitter committer, Runnable readyHandler) { + this(traceId, decoder, partition, committer, readyHandler, new ReaderMetrics(Meter.NOOP, null, null)); + } + + ReadPartitionDecoder(String traceId, MessageDecoder decoder, PartitionSession partition, + MessageCommitter committer, Runnable readyHandler, ReaderMetrics metrics) { this.traceID = traceId; this.decoder = decoder; + this.metrics = metrics; this.partition = partition; this.committer = committer; this.readyHandler = readyHandler; @@ -181,6 +189,7 @@ public void decode(CodecRegistry registry) { return; } + long compressionStarted = 0; try { Codec codec = registry.getCodec(codecCode); if (codec == null) { @@ -190,6 +199,7 @@ public void decode(CodecRegistry registry) { } logger.trace("[{}] Started decoding batch", traceID); + compressionStarted = System.nanoTime(); try (InputStream encoded = origin.newInput(); InputStream decoded = codec.decode(encoded)) { data = ByteStreams.toByteArray(decoded); logger.trace("[{}] Finished decoding batch", traceID); @@ -201,6 +211,8 @@ public void decode(CodecRegistry registry) { problem = new IOException("Cannot decode message", ex); } } finally { + metrics.reportDecoded(compressionStarted == 0 ? 0 : System.nanoTime() - compressionStarted, + System.nanoTime() - getReceivedAt(), codecCode, partition.getPath(), problem); if (problem == null) { origin = null; } else { diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/ReaderMetrics.java b/topic/src/main/java/tech/ydb/topic/read/impl/ReaderMetrics.java index 3ccd4d520..a20c3ea60 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/ReaderMetrics.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/ReaderMetrics.java @@ -6,9 +6,11 @@ import tech.ydb.core.Status; import tech.ydb.core.StatusCode; import tech.ydb.core.metrics.Attr; +import tech.ydb.core.metrics.DoubleHistogram; import tech.ydb.core.metrics.LongCounter; import tech.ydb.core.metrics.Meter; import tech.ydb.core.metrics.MetricRegistration; +import tech.ydb.proto.topic.YdbTopic; /** * Topic reader metrics. @@ -20,6 +22,8 @@ final class ReaderMetrics { private final LongCounter receivedMessages; private final LongCounter receivedBytes; private final LongCounter sessionErrors; + private final DoubleHistogram compressionDuration; + private final DoubleHistogram processingDuration; private final Attr[] commonAttributes; private final boolean enabled; private final Meter meter; @@ -39,6 +43,10 @@ final class ReaderMetrics { "The protocol bytes_size received in read responses."); this.sessionErrors = meter.createCounter("ydb.topic.reader.session.errors", "{error}", "The number of reader stream session errors by retry decision."); + this.compressionDuration = meter.createHistogram("ydb.topic.reader.compression.duration", "s", + "The time spent decompressing a message, excluding queueing."); + this.processingDuration = meter.createHistogram("ydb.topic.reader.message.processing.duration", "s", + "The time from receipt until a message is ready for delivery."); this.commonAttributes = createCommonAttributes(consumer, readerName); } @@ -85,6 +93,27 @@ void reportSessionError(Status status, boolean retry) { sessionErrors.add(1, attributes); } + void reportDecoded(long compressionNanos, long processingNanos, int codec, String topic, Throwable error) { + recordDuration(compressionDuration, compressionNanos, codec, topic, error); + recordDuration(processingDuration, processingNanos, codec, topic, error); + } + + private void recordDuration(DoubleHistogram histogram, long durationNanos, int codec, String topic, + Throwable error) { + if (enabled) { + Attr[] attributes = Arrays.copyOf(commonAttributes, commonAttributes.length + (error == null ? 3 : 4)); + attributes[commonAttributes.length] = Attr.of("topic", topic); + YdbTopic.Codec codecType = YdbTopic.Codec.forNumber(codec); + attributes[commonAttributes.length + 1] = Attr.of("codec", codecType == null ? Integer.toString(codec) + : codecType.name().substring("CODEC_".length()).toLowerCase(java.util.Locale.ROOT)); + attributes[commonAttributes.length + 2] = Attr.of("outcome", error == null ? "ok" : "error"); + if (error != null) { + attributes[commonAttributes.length + 3] = Attr.of("error.type", error.getClass().getName()); + } + histogram.record(durationNanos / 1_000_000_000d, attributes); + } + } + private void report(LongCounter counter, long messages, String topic) { if (enabled && messages > 0) { record(counter, messages, Attr.of("topic", topic)); diff --git a/topic/src/main/java/tech/ydb/topic/write/impl/WriterMetrics.java b/topic/src/main/java/tech/ydb/topic/write/impl/WriterMetrics.java index 29cfbc8a1..755795868 100644 --- a/topic/src/main/java/tech/ydb/topic/write/impl/WriterMetrics.java +++ b/topic/src/main/java/tech/ydb/topic/write/impl/WriterMetrics.java @@ -10,6 +10,7 @@ import tech.ydb.core.metrics.LongCounter; import tech.ydb.core.metrics.Meter; import tech.ydb.core.metrics.MetricRegistration; +import tech.ydb.proto.topic.YdbTopic; /** * Topic writer metrics. @@ -23,6 +24,8 @@ final class WriterMetrics { private final LongCounter sessionErrors; private final DoubleHistogram messageAckDuration; private final DoubleHistogram bufferWaitDuration; + private final DoubleHistogram compressionDuration; + private final DoubleHistogram processingDuration; private final Attr[] commonAttributes; private final Meter meter; private final boolean enabled; @@ -45,6 +48,10 @@ final class WriterMetrics { "Time from first sending a message to the server to its acknowledgement."); this.bufferWaitDuration = meter.createHistogram("ydb.topic.writer.buffer.wait.duration", "s", "Time waiting for buffer capacity before a message is accepted."); + this.compressionDuration = meter.createHistogram("ydb.topic.writer.compression.duration", "s", + "The time spent compressing a message, excluding queueing."); + this.processingDuration = meter.createHistogram("ydb.topic.writer.message.processing.duration", "s", + "The time from buffer acceptance until a message is ready for sending."); this.commonAttributes = writerName == null ? new Attr[0] : new Attr[]{Attr.of("topic", topic), Attr.of("writer.name", writerName)}; @@ -95,6 +102,28 @@ void reportWritten() { writtenMessages.add(1, commonAttributes); } + void reportCompression(long durationNanos, int codec, Throwable error) { + recordDuration(compressionDuration, durationNanos, codec, error); + } + + void reportProcessing(long durationNanos, int codec, Throwable error) { + recordDuration(processingDuration, durationNanos, codec, error); + } + + private void recordDuration(DoubleHistogram histogram, long durationNanos, int codec, Throwable error) { + if (enabled) { + Attr[] attributes = Arrays.copyOf(commonAttributes, commonAttributes.length + (error == null ? 2 : 3)); + YdbTopic.Codec codecType = YdbTopic.Codec.forNumber(codec); + attributes[commonAttributes.length] = Attr.of("codec", codecType == null ? Integer.toString(codec) + : codecType.name().substring("CODEC_".length()).toLowerCase(java.util.Locale.ROOT)); + attributes[commonAttributes.length + 1] = Attr.of("outcome", error == null ? "ok" : "error"); + if (error != null) { + attributes[commonAttributes.length + 2] = Attr.of("error.type", error.getClass().getName()); + } + histogram.record(durationNanos / 1_000_000_000d, attributes); + } + } + void reportSessionError(Status status, boolean retry) { StatusCode code = status.getCode(); Attr[] attributes = Arrays.copyOf(commonAttributes, commonAttributes.length + 3); diff --git a/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java b/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java index 307b37795..a6834fa3f 100644 --- a/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java +++ b/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java @@ -254,7 +254,9 @@ private CompletableFuture accept(Message message, YdbTransaction tx, l if (codec.getId() == Codec.RAW) { // fast track without compression - msg.completeWithData(UnsafeByteOperations.unsafeWrap(message.getData()), reservedSizeBytes); + ByteString data = UnsafeByteOperations.unsafeWrap(message.getData()); + metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), null); + msg.completeWithData(data, reservedSizeBytes); readyNotify.run(); return msg.getAckFuture(); } @@ -262,6 +264,7 @@ private CompletableFuture accept(Message message, YdbTransaction tx, l try { compressionExecutor.execute(() -> encode(message.getData(), reservedSizeBytes, msg)); } catch (Throwable ex) { + metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), ex); logger.warn("[{}] Message wasn't sent because of processing error", debugId, ex); msg.completeWithProblem(ex); readyNotify.run(); @@ -277,9 +280,16 @@ private void encode(byte[] data, long reservedSize, EnqueuedMessage msg) { logger.trace("[{}] Started encoding message", debugId); try (ByteString.Output encoded = ByteString.newOutput()) { - try (OutputStream os = codec.encode(encoded)) { - os.write(data, 0, data.length); + long compressionStarted = System.nanoTime(); + try { + try (OutputStream os = codec.encode(encoded)) { + os.write(data, 0, data.length); + } + } catch (Throwable ex) { + metrics.reportCompression(System.nanoTime() - compressionStarted, codec.getId(), ex); + throw ex; } + metrics.reportCompression(System.nanoTime() - compressionStarted, codec.getId(), null); if (logger.isTraceEnabled()) { logger.trace("[{}] Message compressed from {} to {} bytes", debugId, data.length, encoded.size()); @@ -301,8 +311,10 @@ private void encode(byte[] data, long reservedSize, EnqueuedMessage msg) { } bufferSizeBytes = updatedBufferSizeBytes; + metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), null); msg.completeWithData(encodedData, bufferSizeBytes); } catch (Throwable ex) { + metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), ex); logger.warn("[{}] Message wasn't sent because of encoding error", debugId, ex); msg.completeWithProblem(ex); } From de109bc73b494ca1b36acf9f9a5153ddae8e5150 Mon Sep 17 00:00:00 2001 From: KirillKurdyukov Date: Wed, 21 Oct 2026 16:45:19 +0300 Subject: [PATCH 2/2] Simplify Topic codec duration timing --- .../ydb/topic/read/impl/ReadPartitionDecoder.java | 5 ++--- .../tech/ydb/topic/write/impl/WriterQueue.java | 15 ++++++--------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java index bdf60891d..42c044622 100644 --- a/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java +++ b/topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionDecoder.java @@ -189,7 +189,7 @@ public void decode(CodecRegistry registry) { return; } - long compressionStarted = 0; + long compressionStarted = System.nanoTime(); try { Codec codec = registry.getCodec(codecCode); if (codec == null) { @@ -199,7 +199,6 @@ public void decode(CodecRegistry registry) { } logger.trace("[{}] Started decoding batch", traceID); - compressionStarted = System.nanoTime(); try (InputStream encoded = origin.newInput(); InputStream decoded = codec.decode(encoded)) { data = ByteStreams.toByteArray(decoded); logger.trace("[{}] Finished decoding batch", traceID); @@ -211,7 +210,7 @@ public void decode(CodecRegistry registry) { problem = new IOException("Cannot decode message", ex); } } finally { - metrics.reportDecoded(compressionStarted == 0 ? 0 : System.nanoTime() - compressionStarted, + metrics.reportDecoded(System.nanoTime() - compressionStarted, System.nanoTime() - getReceivedAt(), codecCode, partition.getPath(), problem); if (problem == null) { origin = null; diff --git a/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java b/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java index a6834fa3f..1daf22d17 100644 --- a/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java +++ b/topic/src/main/java/tech/ydb/topic/write/impl/WriterQueue.java @@ -279,17 +279,12 @@ private void encode(byte[] data, long reservedSize, EnqueuedMessage msg) { } logger.trace("[{}] Started encoding message", debugId); + long compressionStarted = System.nanoTime(); try (ByteString.Output encoded = ByteString.newOutput()) { - long compressionStarted = System.nanoTime(); - try { - try (OutputStream os = codec.encode(encoded)) { - os.write(data, 0, data.length); - } - } catch (Throwable ex) { - metrics.reportCompression(System.nanoTime() - compressionStarted, codec.getId(), ex); - throw ex; + try (OutputStream os = codec.encode(encoded)) { + os.write(data, 0, data.length); } - metrics.reportCompression(System.nanoTime() - compressionStarted, codec.getId(), null); + long compressionDuration = System.nanoTime() - compressionStarted; if (logger.isTraceEnabled()) { logger.trace("[{}] Message compressed from {} to {} bytes", debugId, data.length, encoded.size()); @@ -311,9 +306,11 @@ private void encode(byte[] data, long reservedSize, EnqueuedMessage msg) { } bufferSizeBytes = updatedBufferSizeBytes; + metrics.reportCompression(compressionDuration, codec.getId(), null); metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), null); msg.completeWithData(encodedData, bufferSizeBytes); } catch (Throwable ex) { + metrics.reportCompression(System.nanoTime() - compressionStarted, codec.getId(), ex); metrics.reportProcessing(System.nanoTime() - msg.getAcceptedTimestamp(), codec.getId(), ex); logger.warn("[{}] Message wasn't sent because of encoding error", debugId, ex); msg.completeWithProblem(ex);