Merge pull request #50 from wordpress-mobile/issue/42-by-pass-passlock

theck13 · web-flow · commit 59d50378832e · 2016-11-30T22:28:06.000-07:00
[Facepalm] PIN input screen can be easily bypassed
diff --git a/library/src/org/wordpress/passcodelock/DefaultAppLock.java b/library/src/org/wordpress/passcodelock/DefaultAppLock.java
@@ -39,7 +39,7 @@ public DefaultAppLock(Application app) {
     /** {@link PasscodeUnlockActivity} is always exempt. */
     @Override
     public boolean isExemptActivity(String activityName) {
-        return !UNLOCK_CLASS_NAME.equals(activityName) && super.isExemptActivity(activityName);
+        return UNLOCK_CLASS_NAME.equals(activityName) || super.isExemptActivity(activityName);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public DefaultAppLock(Application app) {`
`39`	`39`	`/** {@link PasscodeUnlockActivity} is always exempt. */`
`40`	`40`	`@Override`
`41`	`41`	`public boolean isExemptActivity(String activityName) {`
`42`		`- return !UNLOCK_CLASS_NAME.equals(activityName) && super.isExemptActivity(activityName);`
	`42`	`+ return UNLOCK_CLASS_NAME.equals(activityName) \|\| super.isExemptActivity(activityName);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`@Override`