Catch up with rubocop cop updates

- Exclude Style/OneClassPerFile in offending files.
- When building ast_node_children in lib/rubycritic/analysers/helpers/ast_node.rb, use grep instead of select with a kind check (Style/SelectByKind)
- When generating hash in RubyCritic::AnalysisSummary, use to_h directly (Style/ReduceToHash)

Author: faisal

.rubocop.yml

@@ -72,6 +72,13 @@ Style/Documentation:
 Style/HashSyntax:
   EnforcedShorthandSyntax: either
 
+Style/OneClassPerFile:
+  Exclude:
+    - 'lib/rubycritic/analysers/helpers/ast_node.rb'
+    - 'test/analysers_test_helper.rb'
+    - 'test/fakefs_helper.rb'
+    - 'test/test_helper.rb'
+
 Style/OpenStructUse:
   Exclude:
     - 'test/lib/rubycritic/generators/turbulence_test.rb'

lib/rubycritic/analysers/helpers/ast_node.rb

@@ -23,9 +23,7 @@ def recursive_children(&block)
       end
 
       def module_names
-        ast_node_children = children.select do |child|
-          child.is_a?(Parser::AST::Node)
-        end
+        ast_node_children = children.grep(Parser::AST::Node)
 
         children_modules = ast_node_children.flat_map(&:module_names)
 

lib/rubycritic/analysis_summary.rb

@@ -11,9 +11,7 @@ def initialize(analysed_modules)
     end
 
     def generate
-      %w[A B C D F].each_with_object({}) do |rating, summary|
-        summary[rating] = generate_for(rating)
-      end
+      %w[A B C D F].to_h { |rating| [rating, generate_for(rating)] }
     end
 
     private