[WV-2660] Election Finder: National filter fix, date-below-title layout, About office on candidates#4818
Merged
Conversation
Contributor
ric0de
commented
May 19, 2026
ric0de
commented
- Fix /election-finder/na: match elections explicitly tagged state_code='NA' (or 'NA' in state_code_list) instead of treating empty state_code_list as national, which was sweeping in state-level elections that just have unpopulated lists.
- Add "National" option to the state dropdown (top of list, above alphabetical states) on Home and ForState.
- Stack title and date vertically: title on top, date below in "Mon D, YYYY" format. On Home, non-national rows prefix the election name with " - "
- Add "About office" entry to the candidate row in both the desktop action bar and the kebab menu, gated behind nextReleaseFeaturesEnabled, stub onClick — mirroring the office row exactly.
…ut, About office on candidates - Fix /election-finder/na: match elections explicitly tagged state_code='NA' (or 'NA' in state_code_list) instead of treating empty state_code_list as national, which was sweeping in state-level elections that just have unpopulated lists. - Add "National" option to the state dropdown (top of list, above alphabetical states) on Home and ForState. - Stack title and date vertically: title on top, date below in "Mon D, YYYY" format. On Home, non-national rows prefix the election name with "<State> - <Election Name>" (en dash). - Add "About office" entry to the candidate row in both the desktop action bar and the kebab menu, gated behind nextReleaseFeaturesEnabled, stub onClick — mirroring the office row exactly.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.