From f02f77ac0b1b9d7d8419e7e727efbee53dc9b468 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 31 Aug 2026 04:06:12 +0000 Subject: [PATCH 1/2] Bump rubocop from 1.89.0 to 1.90.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.89.0 to 1.90.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.89.0...v1.90.0) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.90.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index ad2419a..c8c89bd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -92,8 +92,8 @@ GEM diff-lcs (>= 1.2.0, < 2.0) rspec-support (~> 3.13.0) rspec-support (3.13.6) - rubocop (1.89.0) - json (~> 2.3) + rubocop (1.90.0) + json (>= 2.3) language_server-protocol (~> 3.17.0.2) lint_roller (~> 1.1.0) parallel (>= 1.10) From 2b19cd5ac95b26d2e2c16ebfc23c398eb20cc4fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89douard=20Bri=C3=A8re?= Date: Mon, 31 Aug 2026 07:04:13 +0100 Subject: [PATCH 2/2] style: Satisfy the new RuboCop 1.90.0 cops RuboCop 1.90.0 adds Style/DirectiveScope, which flags a `rubocop:todo`/`rubocop:enable` pair wrapping a single statement and asks for `rubocop:todo-next` instead. Applied rubocop's own autocorrect to the two `cleanup` methods in the S3 and SFTP backends; both `def` lines already carry an inline directive listing the same cops, so nothing changes about what is suppressed. Separately, the directive in the archive integration spec read `Rspec/Output`, which is not a real cop name and so never suppressed anything. 1.90.0 reports the near-miss via Lint/RedundantCopDisableDirective while RSpec/Output itself fires on the `puts`. Corrected the casing to `RSpec/Output`. Claude-Session: https://claude.ai/code/session_016TgzEzGneJQhZ3wmhvysxE --- lib/web_translate_it/safe/s3.rb | 3 +-- lib/web_translate_it/safe/sftp.rb | 3 +-- spec/integration/archive_integration_spec.rb | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/web_translate_it/safe/s3.rb b/lib/web_translate_it/safe/s3.rb index 9d36d97..e7d63e3 100644 --- a/lib/web_translate_it/safe/s3.rb +++ b/lib/web_translate_it/safe/s3.rb @@ -40,7 +40,7 @@ def save # rubocop:todo Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/M puts("Upload took #{format('%.2f', benchmark)} second(s).") if verbose? end - # rubocop:todo Metrics/PerceivedComplexity + # rubocop:todo-next Metrics/PerceivedComplexity def cleanup # rubocop:todo Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize, Metrics/MethodLength return if local_only? @@ -59,7 +59,6 @@ def cleanup # rubocop:todo Metrics/CyclomaticComplexity, Metrics/PerceivedComple AWS::S3::Bucket.objects(bucket, prefix: f)[0].delete unless dry_run? || local_only? end end - # rubocop:enable Metrics/PerceivedComplexity def bucket config[:s3, :bucket] diff --git a/lib/web_translate_it/safe/sftp.rb b/lib/web_translate_it/safe/sftp.rb index 3b64d4e..0d21e59 100644 --- a/lib/web_translate_it/safe/sftp.rb +++ b/lib/web_translate_it/safe/sftp.rb @@ -61,7 +61,7 @@ def save # rubocop:todo Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/P puts '...done' if verbose? end - # rubocop:todo Metrics/PerceivedComplexity + # rubocop:todo-next Metrics/PerceivedComplexity def cleanup # rubocop:todo Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/AbcSize, Metrics/MethodLength return if local_only? || dry_run? @@ -85,7 +85,6 @@ def cleanup # rubocop:todo Metrics/CyclomaticComplexity, Metrics/PerceivedComple end end end - # rubocop:enable Metrics/PerceivedComplexity def host config[:sftp, :host] diff --git a/spec/integration/archive_integration_spec.rb b/spec/integration/archive_integration_spec.rb index 0ba7653..4036aa5 100644 --- a/spec/integration/archive_integration_spec.rb +++ b/spec/integration/archive_integration_spec.rb @@ -60,7 +60,7 @@ system "tar -zxvf #{@backup} -C #{@target}" @test = "#{@target}/#{@root}/src" - puts @test # rubocop:todo Rspec/Output + puts @test # rubocop:todo RSpec/Output end it 'includes asd1/2/3' do