Skip to content

[TASK] Fix CI failures - TypeScript errors, linting, and tests #150

@codewizdave

Description

@codewizdave

Description

Fix the existing CI pipelines that are currently failing. The CI workflows already exist but are broken due to code issues.

Current State

CI workflows exist and run on PRs:

  • check.yaml - Runs npm run check
  • lint.yaml - Runs ultracite lint
  • types.yaml - Runs npx tsc --noEmit
  • testing.yaml - Runs unit and E2E tests

All CI jobs are currently failing.

Issues Identified

  1. TypeScript errors: 1055 errors blocking types.yaml

    • 77 from node_modules (need skipLibCheck: true)
    • ~978 from src/ (import issues, type mismatches)
  2. Lint/Format issues: Multiple files not properly formatted

  3. Tests: Only 3 test files exist, only 1 passes

Requirements

TypeScript Fixes

  • Add skipLibCheck: true to tsconfig.json
  • Fix duplicate imports in src/core/ipc/database/handlers.ts
  • Add missing schema exports (media, notes) or remove unused imports
  • Fix type mismatches in handlers

Lint Fixes

  • Run npm run fix to auto-fix formatting issues
  • Manually fix what can't be auto-fixed

Test Coverage

  • Fix existing failing tests
  • Add tests for IPC handlers
  • Add tests for database operations

Priority

  • priority:high

Effort

  • effort:l

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions