Add allowed namespaces to vshngarage#682
Open
mikeshootzz wants to merge 1 commit into
Open
Conversation
This uses the GarageReferenceGrant to restrict where GarageKeys and GarageBuckets can be provisioned.
3 tasks
Contributor
|
mikeshootzz
requested review from
a team,
Kidswiss,
TheBigLee,
mdnix and
zugao
and removed request for
a team
TheBigLee
approved these changes
May 21, 2026
Comment on lines
+24
to
+28
| // applyAllowedNamespaces decodes the comma-coupled JSON list provided through | ||
| // the comp-function xfn-config (key: garageAllowedNamespaces) and injects it | ||
| // into the vshngaragecluster chart values. Empty input leaves values | ||
| // untouched so older component-appcat releases that don't ship the key keep | ||
| // working — the chart simply skips the GarageReferenceGrant template. |
Member
There was a problem hiding this comment.
Suggested change
| // applyAllowedNamespaces decodes the comma-coupled JSON list provided through | |
| // the comp-function xfn-config (key: garageAllowedNamespaces) and injects it | |
| // into the vshngaragecluster chart values. Empty input leaves values | |
| // untouched so older component-appcat releases that don't ship the key keep | |
| // working — the chart simply skips the GarageReferenceGrant template. | |
| // applyAllowedNamespaces decodes the JSON array through | |
| // the comp-functions config key (`garageAllowedNamespaces`) and injects it | |
| // into the vshngaragecluster chart values. | |
| // An empty input leaves values untouched, for backwards compatibility. | |
| // the chart simply skips the GarageReferenceGrant template. |
zugao
approved these changes
May 21, 2026
| // into the vshngaragecluster chart values. Empty input leaves values | ||
| // untouched so older component-appcat releases that don't ship the key keep | ||
| // working — the chart simply skips the GarageReferenceGrant template. | ||
| func applyAllowedNamespaces(values map[string]any, raw string) error { |
Collaborator
There was a problem hiding this comment.
nit: for reading purposes I would move this function at the bottom
zugao
reviewed
May 21, 2026
| } | ||
|
|
||
| if err := applyAllowedNamespaces(values, svc.Config.Data["garageAllowedNamespaces"]); err != nil { | ||
| return runtime.NewFatalResult(err) |
Collaborator
There was a problem hiding this comment.
Can this fatal error return too early and try to delete managed resources?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syn-appcatis included by default so AppCat can provision the buckets as normalChecklist
/mergecomment.Component PR: vshn/component-appcat#1193