From 13b9c3c9824d3019ffdbc9645b6c823bd13c3b4f Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:21:49 +0100 Subject: [PATCH 1/6] add workflow typo add pwd --- .github/workflows/audit.yaml | 18 ++++++++++++++++++ exercise-1/audit.yaml | 6 ------ 2 files changed, 18 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/audit.yaml delete mode 100644 exercise-1/audit.yaml diff --git a/.github/workflows/audit.yaml b/.github/workflows/audit.yaml new file mode 100644 index 0000000..4748d72 --- /dev/null +++ b/.github/workflows/audit.yaml @@ -0,0 +1,18 @@ +name: Code Audit + +on: + pull_request: + branches: + - master + +jobs: + lint: + name: lint + runs-on: ubuntu-latest + steps: + - name: Lint pages + run: | + pwd + cd exercise-1 + npm ci + npm run lint diff --git a/exercise-1/audit.yaml b/exercise-1/audit.yaml deleted file mode 100644 index b652e03..0000000 --- a/exercise-1/audit.yaml +++ /dev/null @@ -1,6 +0,0 @@ -name: Code Audit - -on: push - -jobs: -# https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions From a957e4899d3f3b6daa9fe37de5fee744b8009e28 Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:28:29 +0100 Subject: [PATCH 2/6] checkout repo cleanup --- .github/workflows/audit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/audit.yaml b/.github/workflows/audit.yaml index 4748d72..4ac6630 100644 --- a/.github/workflows/audit.yaml +++ b/.github/workflows/audit.yaml @@ -10,9 +10,9 @@ jobs: name: lint runs-on: ubuntu-latest steps: + - uses: actions/checkout@v2 - name: Lint pages run: | - pwd cd exercise-1 npm ci npm run lint From ca8af49f71db66b72f189fefadb60177ab6920dc Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:30:59 +0100 Subject: [PATCH 3/6] remove debugger statement --- exercise-1/pages/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/exercise-1/pages/index.js b/exercise-1/pages/index.js index 2eeb933..abb83d6 100644 --- a/exercise-1/pages/index.js +++ b/exercise-1/pages/index.js @@ -1,4 +1,3 @@ export default function funFunFunction() { - debugger; return

Oh hi there

} From 60e30f069687781ce31a6d3072860f616fc6e012 Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:47:24 +0100 Subject: [PATCH 4/6] Add log-stuff workflow --- .github/workflows/log-stuff.yaml | 13 +++++++++++++ exercise-2/log-stuff.yaml | 8 -------- 2 files changed, 13 insertions(+), 8 deletions(-) create mode 100644 .github/workflows/log-stuff.yaml delete mode 100644 exercise-2/log-stuff.yaml diff --git a/.github/workflows/log-stuff.yaml b/.github/workflows/log-stuff.yaml new file mode 100644 index 0000000..4ffdf14 --- /dev/null +++ b/.github/workflows/log-stuff.yaml @@ -0,0 +1,13 @@ +name: Log stuff + +on: pull_request + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + + - uses: ./.github/actions/its-local + with: + message: 'It is Friday!' diff --git a/exercise-2/log-stuff.yaml b/exercise-2/log-stuff.yaml deleted file mode 100644 index 1f99a73..0000000 --- a/exercise-2/log-stuff.yaml +++ /dev/null @@ -1,8 +0,0 @@ -name: Log stuff - -on: pull_request - -jobs: - lint: - runs-on: ubuntu-latest - steps: From 641b0202d2e12d6d1f9f0113ac71ea67e618a7f2 Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:49:09 +0100 Subject: [PATCH 5/6] update path --- .github/workflows/log-stuff.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/log-stuff.yaml b/.github/workflows/log-stuff.yaml index 4ffdf14..4761a36 100644 --- a/.github/workflows/log-stuff.yaml +++ b/.github/workflows/log-stuff.yaml @@ -8,6 +8,6 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: ./.github/actions/its-local + - uses: ./exercise-2/it-local with: message: 'It is Friday!' From 841fa316c5828cadfd304747135756ee5433e616 Mon Sep 17 00:00:00 2001 From: Peter Goes Date: Fri, 5 Feb 2021 09:49:54 +0100 Subject: [PATCH 6/6] fix typo --- .github/workflows/log-stuff.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/log-stuff.yaml b/.github/workflows/log-stuff.yaml index 4761a36..9b825de 100644 --- a/.github/workflows/log-stuff.yaml +++ b/.github/workflows/log-stuff.yaml @@ -8,6 +8,6 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: ./exercise-2/it-local + - uses: ./exercise-2/its-local with: message: 'It is Friday!'