Skip to content

Commit a10f67d

Browse files
committed
Fix mislabeled llama.cpp model storage default in Settings
The llama.cpp (local) section reused the Ollama section's 'Default (Ollama's own location)' label for its own model storage location — but per getLlamaCppModelsDir() in main.ts, the actual default is a dedicated <userData>/llamacpp-models folder, entirely separate from where Ollama stores its own blobs. The mislabeled UI told users their GGUF files belonged in Ollama's directory, which they do not — Ollama's blob store is content-addressed (sha256-named, no extension) and llama.cpp's listModels() only scans a flat folder for *.gguf files directly, not inside it. Also added a hint explaining this, since the row previously had none at all.
1 parent f1a0b67 commit a10f67d

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

frontend/src/lib/translations.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ export interface Dictionary {
126126
modelsDir: string;
127127
modelsDirHint: string;
128128
modelsDirDefault: string;
129+
llamaCppModelsDirDefault: string;
130+
llamaCppModelsDirHint: string;
129131
chooseFolder: string;
130132
modelsDirApplied: string;
131133
modelsDirFailed: string;
@@ -490,6 +492,8 @@ export const en: Dictionary = {
490492
modelsDir: "Model storage location",
491493
modelsDirHint: "Where Ollama downloads and stores model files. Changing this restarts Ollama (only if this app started it) — running downloads will be interrupted.",
492494
modelsDirDefault: "Default (Ollama's own location)",
495+
llamaCppModelsDirDefault: "Default (app data folder)",
496+
llamaCppModelsDirHint: "Where llama.cpp looks for .gguf files — separate from Ollama's own storage above. Files must sit directly in this folder (not a subfolder) with a .gguf extension.",
493497
chooseFolder: "Choose folder...",
494498
modelsDirApplied: "Applied — Ollama restarted with the new location.",
495499
modelsDirFailed: "Couldn't restart Ollama with the new location. Try starting it manually.",
@@ -863,6 +867,8 @@ export const tr: Dictionary = {
863867
modelsDir: "Model depolama konumu",
864868
modelsDirHint: "Ollama'nın model dosyalarını indirdiği ve sakladığı yer. Bunu değiştirmek Ollama'yı yeniden başlatır (yalnızca bu uygulama başlattıysa) — devam eden indirmeler kesintiye uğrar.",
865869
modelsDirDefault: "Varsayılan (Ollama'nın kendi konumu)",
870+
llamaCppModelsDirDefault: "Varsayılan (uygulama veri klasörü)",
871+
llamaCppModelsDirHint: "llama.cpp'nin .gguf dosyalarını aradığı yer — yukarıdaki Ollama'nın kendi deposundan ayrıdır. Dosyalar bir alt klasörde değil, doğrudan bu klasörde olmalı ve .gguf uzantılı olmalıdır.",
866872
chooseFolder: "Klasör seç...",
867873
modelsDirApplied: "Uygulandı — Ollama yeni konumla yeniden başlatıldı.",
868874
modelsDirFailed: "Ollama yeni konumla yeniden başlatılamadı. Elle başlatmayı deneyin.",

frontend/src/pages/Settings.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1072,10 +1072,10 @@ export default function Settings() {
10721072
</SelectContent>
10731073
</Select>
10741074
</SettingsRow>
1075-
<SettingsRow label={t.modelsDir} stacked>
1075+
<SettingsRow label={t.modelsDir} description={t.llamaCppModelsDirHint} stacked>
10761076
<div className="flex flex-wrap items-center gap-2">
10771077
<span className="truncate rounded border border-border bg-muted px-2 py-1 font-mono text-xs">
1078-
{settings.llamaCppModelsDir ?? t.modelsDirDefault}
1078+
{settings.llamaCppModelsDir ?? t.llamaCppModelsDirDefault}
10791079
</span>
10801080
<Button
10811081
size="sm"

0 commit comments

Comments
 (0)