Strip em dashes and emojis, trim noisy comments#9
Merged
Conversation
Make output and source plain ASCII. Replace em dashes with normal
punctuation across code, docs, and CLI strings. Drop the hammer from
the CLI about text. Switch validate's check/cross markers to OK / WARN
/ FAIL so the output stays readable in any terminal.
Drop comments that just restate the next line of code (e.g. "Load
config", "Pre-resolve hooks", "Replace \${VERSION} with package
version") and the decorative section banners in main.rs and
context.rs. Keep the comments that explain non-obvious decisions
(tempdir leak, cache salt, alias resolution, override warning,
tilde-at-segment expansion, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make output and source plain ASCII. Replace em dashes with normal
punctuation across code, docs, and CLI strings. Drop the hammer from
the CLI about text. Switch validate's check/cross markers to OK / WARN
/ FAIL so the output stays readable in any terminal.
Drop comments that just restate the next line of code (e.g. "Load
config", "Pre-resolve hooks", "Replace ${VERSION} with package
version") and the decorative section banners in main.rs and
context.rs. Keep the comments that explain non-obvious decisions
(tempdir leak, cache salt, alias resolution, override warning,
tilde-at-segment expansion, etc.).