Skip to content

Build works fine as is up to 24.7.12, breaks starting 24.8.1 unless reactEnabled=false is removed #3

@eischet

Description

@eischet

What a great idea!

I've been trying this out with newer Vaadin versions, and can easily produce bundles up to 24.7.12 just by changing the Vaadin version in the main pom.

However, starting with 24.8.1 and including the current 24.8.5, the build fails like this:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Viritin Widgetset parent project 24.6.6-SNAPSHOT:
[INFO]
[INFO] Viritin Widgetset parent project ................... SUCCESS [  0.001 s]
[INFO] Core Widgetset ..................................... FAILURE [  8.956 s]
[INFO] Viritin Widgetset and Spring Boot .................. SKIPPED
[INFO] Viritin JBang Starter .............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.011 s
[INFO] Finished at: 2025-08-08T12:27:28+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.vaadin:vaadin-maven-plugin:24.8.5:build-frontend (frontend) on project core: null: MojoFailureException: InvocationTargetException: Vite process exited with non-zero exit code.
[ERROR] Stderr: 'vite v6.3.5 building for production...
[ERROR] (node:8254) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
[ERROR] (Use `node --trace-deprecation ...` to show where the warning was created)
[ERROR] transforming...
[ERROR] target/plugins/vite-plugin-service-worker/index.ts(1,23): error TS2688: Cannot find type definition file for 'node'.
[ERROR] target/plugins/vite-plugin-service-worker/index.ts(2,35): error TS2307: Cannot find module 'node:path' or its corresponding type declarations.
[ERROR] ': Unexpected exit value: 2, allowed exit values: [0], executed command [/opt/homebrew/bin/node, /Users/stefan/projects/thirdparty/widgetset-y/core/node

I can repair the build be simply commenting out the core/pom.xml line that disables react.
I'm not sure why this is needed, but I thought I'd leave a note here so others can save the hour or two it took me to find out. ;-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions