pattern.sh make load-secrets fails with "The conditional check 'vault_ns_rc.resources | length > 0' failed"

[ngner]

/pattern.sh make load-secrets

make -f common/Makefile load-secrets
make[1]: Entering directory '/home/nday/workspace/github/multicloud-gitops'

common/scripts/process-secrets.sh multicloud-gitops

[WARNING]: No inventory was parsed, only implicit localhost is available

PLAY [Parse and load secrets] *************************************************************************************************************************************************************************************

TASK [Run secret-loading pre-requisites] **************************************************************************************************************************************************************************

TASK [rhvp.cluster_utils.cluster_pre_check : Check if the kubernetes python module is usable from ansible] ********************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.cluster_pre_check : Check if KUBECONFIG is correctly set] ********************************************************************************************************************************
skipping: [localhost]

TASK [rhvp.cluster_utils.cluster_pre_check : Check if ~/.kube/config exists] **************************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.cluster_pre_check : Check if we're running inside an OCP cluster directly] ***************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.cluster_pre_check : Fail if both KUBECONFIG and ~/.kube/config do not exist but only when not running in a cluster] **********************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Set secret_template fact] **********************************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Is a VALUES_SECRET env variable set?] **********************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Check if VALUES_SECRET file exists] ************************************************************************************************************************************
skipping: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Set values-secret yaml file to {{ custom_file_values_secret.stat.path }}] **********************************************************************************************
skipping: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Find first existing values-secret yaml file] ***************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Is found values secret file encrypted] *********************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Is found values secret file encrypted] *********************************************************************************************************************************
ok: [localhost] => {
"msg": "Using ~/values-secret-multicloud-gitops.yaml to parse secrets"
}

TASK [rhvp.cluster_utils.find_vp_secrets : Set encryption bool fact] **********************************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Get password for "/pattern-home/values-secret-multicloud-gitops.yaml"] *************************************************************************************************
skipping: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Get decrypted content if /pattern-home/values-secret-multicloud-gitops.yaml was encrypted] *****************************************************************************
skipping: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Normalize secrets format (un-encrypted)] *******************************************************************************************************************************
ok: [localhost]

TASK [rhvp.cluster_utils.find_vp_secrets : Normalize secrets format (encrypted)] **********************************************************************************************************************************
skipping: [localhost]

TASK [Determine how to load secrets] ******************************************************************************************************************************************************************************
ok: [localhost]

TASK [Parse secrets data] *****************************************************************************************************************************************************************************************
ok: [localhost]

TASK [Determine role to use to load secrets] **********************************************************************************************************************************************************************
skipping: [localhost]

TASK [Load secrets using designated role and tasks] ***************************************************************************************************************************************************************

TASK [Do pre-checks for Vault] ************************************************************************************************************************************************************************************

TASK [rhvp.cluster_utils.vault_utils : Check for vault namespace] *************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"msg": "The conditional check 'vault_ns_rc.resources | length > 0' failed. The error was: error while evaluating conditional (vault_ns_rc.resources | length > 0): 'dict object' has no attribute 'resources'. 'dict object' has no attribute 'resources'"}

PLAY RECAP ********************************************************************************************************************************************************************************************************
localhost : ok=13 changed=0 unreachable=0 failed=1 skipped=7 rescued=0 ignored=0

make[1]: *** [common/Makefile:96: load-secrets] Error 2
make[1]: Leaving directory '/home/nday/workspace/github/multicloud-gitops'
make: *** [Makefile:12: load-secrets] Error 2

[ngner]

The vault namespace exists and the vault ArgoCD application is deployed but without a complete statefult set which I believe relates to the lack of secret.
oc get namespace | grep vault
vault Active 21h

[mbaldessari]

Vault by default will need a defaultStorageClass in order to claim storage to store the secret db. Do you have that on your cluster? (In any case we should make this error out more clearly either at install phase or in the load-secret phase)