Skip to content

chore: add CI gate before release + pin action versions to commit SHAs #15

@jflowers

Description

@jflowers

Summary

Two related supply-chain hygiene issues:

1. No CI gate before release

release.yml triggers on any v* tag push and runs GoReleaser immediately with no CI preflight verification. A tag pushed from a commit that never passed tests will produce and distribute release binaries.

2. Floating action tags

CI workflows use mutable floating action tags (actions/checkout@v4, actions/setup-go@v5) instead of commit SHA pins. All other repos in the org pin actions to full commit SHAs. The project's own severity.md classifies unpinned CI actions on mutable tags as HIGH severity supply-chain risk.

Expected behavior

  1. Release preflight: Before GoReleaser runs, verify that Build and Test CI checks passed on the tagged commit (matching the pattern in unbound-force/unbound-force/.github/workflows/release.yml lines 78-110)
  2. Pin actions: Replace floating tags with full commit SHAs (e.g., actions/checkout@v4 -> actions/checkout@<commit-sha>)

Location

  • .github/workflows/release.yml
  • .github/workflows/ci.yml

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions