problem with named parameters?

[mitelg]

I tried the new version and now there is an issue with attributes and probably named parameters? 🤔

-> https://github.com/shopware/shopware/blob/trunk/src/Core/Content/MeasurementSystem/DataAbstractionLayer/MeasurementSystemEntity.php#L40
-> https://github.com/shopware/shopware/blob/trunk/src/Core/Framework/DataAbstractionLayer/Attribute/OneToMany.php

PHP Fatal error: Uncaught TypePHP\Exception\TypeError: Shopware\Core\Framework\DataAbstractionLayer\Attribute\OneToMany::__construct(): Argument $onDelete must be of type (bool | array{admin-api: bool, store-api: bool}), Shopware\Core\Framework\DataAbstractionLayer\Attribute\OnDelete given in /home/runner/work/shopware/shopware/src/Core/Content/MeasurementSystem/DataAbstractionLayer/MeasurementSystemEntity.php:40

[rcalicdan]

Hello @mitelg , you are indeed correct the i had look at the internal ast parsing of the library and it doesn't take into account on the positioning of name parameters in constructors and I had reproduce the same errors in my test suites. I will release a new version with this fix along with new features and performance improvements of the library later soon.

I appreciate the help for submitting bugs.

[rcalicdan]

Hello @mitelg

I manage to fix your issue in #10 and 0.2.0 release and fix the reproduce errors in my test suites and added more edge cases tests..
you can update the library version in composer now to see how it goes in your codebase.

Thank you for submitting this bug report,, If you still find any problems feel free to submit or ask questions.