Refactor User class and add HookedUser class with asymmetric visibility properties; update tests to validate property hooks

Author: rcalicdan

tests/Fixtures/Domain/User.php

@@ -6,28 +6,9 @@
 
 class User
 {
-    /**
-     * Asymmetric visibility property with @var constraint
-     *
-     * @var positive-int
-     */
-    public private(set) int $id = 10;
-
-    /**
-     * Property hook with asymmetric visibility and @var constraint
-     *
-     * @var non-empty-string
-     */
-    public protected(set) string $username {
-        get => $this->_username;
-        set => $this->_username = trim($value);
-    }
-
-    private string $_username = 'Alice';
-
-    public function updateProfile(int $newId, string $newUsername): void
-    {
-        $this->id = $newId;           // Validated against @var positive-int!
-        $this->username = $newUsername; // Validated in set hook against @var non-empty-string!
+    public function __construct(
+        public string $name = 'Alice',
+        public int $id = 1
+    ) {
     }
-}
+}

tests/Fixtures/Types/HookedUser.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TypePHP\Tests\Fixtures\Types;
+
+class HookedUser
+{
+    /**
+     * Asymmetric visibility property with @var constraint
+     *
+     * @var positive-int
+     */
+    public private(set) int $id = 10;
+
+    /**
+     * Property hook with asymmetric visibility and @var constraint
+     *
+     * @var non-empty-string
+     */
+    public protected(set) string $username {
+        get => $this->_username;
+        set => $this->_username = trim($value);
+    }
+
+    private string $_username = 'Alice';
+
+    public function updateProfile(int $newId, string $newUsername): void
+    {
+        $this->id = $newId;
+        $this->username = $newUsername;
+    }
+}

tests/TypeChecking/Boundaries/PropertyHooksTest.php

@@ -7,8 +7,8 @@
 }
 
 use TypePHP\Internal\Config;
-use TypePHP\Tests\Fixtures\Domain\User;
 use TypePHP\Tests\Fixtures\Types\HookedInterfaceImplementation;
+use TypePHP\Tests\Fixtures\Types\HookedUser;
 use TypePHP\Tests\Fixtures\Types\PropertyHooks;
 
 beforeEach(function () {
@@ -76,8 +76,8 @@
         expect($fixture->unvalidatedHook)->toBe(-50);
     });
 
-    test('validates asymmetric visibility properties combined with property hooks', function () {
-        $profile = new User();
+     test('validates asymmetric visibility properties combined with property hooks', function () {
+        $profile = new HookedUser();
 
         $profile->updateProfile(100, 'Bob');
         expect($profile->id)->toBe(100);