fix(webapp): remove unawaited task list metrics promises (#4380)

<!-- ccr-slack-attribution -->
_Requested via [Slack
thread](https://triggerdotdev.slack.com/archives/C097ZHVKZFA/p1785082528841609)_

`TaskListPresenter` created promises that nothing ever consumed. Two of
the three deferred metrics promises it returned had no reader, no
`await` and no `.catch()`, so when the query behind one of them failed
the rejection had nowhere to go.

## Before / After

**Before**

- `TaskListPresenter.call()` returned four things: `tasks`, `activity`,
`runningStats` and `durations`. Its only caller reads `tasks` and
`runningStats`.
- Every load of the tasks page therefore fired two ClickHouse queries
whose results were thrown away.
- If either of those two queries failed, the resulting promise rejection
was unhandled — nothing was awaiting it and nothing had attached an
error handler, so it surfaced as an unhandled rejection at the process
level rather than as an error anyone could attribute to a request.

**After**

- `TaskListPresenter.call()` returns `tasks` and `runningStats` only.
- Two fewer queries run per tasks-page load.
- There is no longer an unconsumed promise that can reject without a
handler. `runningStats` is awaited by its caller, so its failures
continue to be handled the way they always were.

Nothing changes on screen: the tasks page renders `hourlyActivity` and
`runningStates`, and neither of the removed values fed either of those.

## How

The removed values were verified unreferenced before deleting anything:

- `TaskListPresenter` has exactly one caller,
`UnifiedTaskListPresenter`, which reads `taskResult.tasks` and
`taskResult.runningStats` and nothing else.
- No file anywhere in the repo — app code, tests, or type re-exports —
reads an `activity` or `durations` field off the presenter's result.
- `UnifiedTaskListPresenter` builds its own
`unifiedTaskListHourlyActivity` query for the 24h chart the page
actually renders, which is what made the presenter's separate 7-day
daily activity data redundant.
- `getDailyTaskActivity` and `getAverageDurations` on
`ClickHouseEnvironmentMetricsRepository` had no callers other than the
two lines being deleted, so they and their now-orphaned helpers and
types were removed too.

Changes:

- `apps/webapp/app/presenters/v3/TaskListPresenter.server.ts` — drop the
`activity` and `durations` fields (both from the main return and from
the no-current-worker early return) and the two repository calls behind
them. Drop the unreferenced `TaskActivity` type alias. The "don't await
this" comment on the remaining `runningStats` promise now spells out
that the caller has to consume it.
- `apps/webapp/app/services/environmentMetricsRepository.server.ts` —
remove `getDailyTaskActivity` and `getAverageDurations` from the
`EnvironmentMetricsRepository` interface and its ClickHouse
implementation, along with `fillInDailyTaskActivity` and the
`DailyTaskActivity` / `AverageDurations` types.

`getCurrentRunningStats` is the control that shows the diagnosis is
right. It throws on query failure in exactly the same way as the two
removed methods — `if (queryError) throw queryError` — but it never
produced an unhandled rejection, because `UnifiedTaskListPresenter`
passes its promise into a `Promise.all(...).then(...)` chain that the
route then awaits. Same failure mode, opposite outcome, and the only
difference is whether anything consumes the promise.

Follow-ups, not in this PR:

- `AgentListPresenter` returns three sparkline promises in the same
shape and they look similarly unconsumed. Left alone here to keep this
change reviewable.
- With these two callers gone, the `getTaskActivity` and
`getAverageDurations` query builders in `@internal/clickhouse` have no
remaining callers in this repo. Whether to remove them is a separate
call for someone who owns that package.

## ✅ Checklist

- [x] I have followed every step in the [contributing
guide](https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md)
- [x] The PR title follows the convention.
- [x] I ran and tested the code works

---

## Testing

- `pnpm run typecheck --filter webapp` — passes. This is the meaningful
check here: it proves nothing still references the removed fields,
methods or types.
- `pnpm run format` and `pnpm run lint:fix` — clean, no changes
produced.
- No test file referenced the removed symbols, so no test needed
updating.

---

## Changelog

Server-only change, so this carries a `.server-changes/` note rather
than a changeset:
`.server-changes/task-list-remove-unused-metrics-queries.md`.

> The tasks page no longer runs two queries whose results were never
displayed, cutting wasted work on every page load and removing a source
of hidden server errors

---

## Screenshots

_No visual change — the removed data was never rendered._

Co-authored-by: Claude <noreply@anthropic.com>

Author: claude[bot]

.server-changes/task-list-remove-unused-metrics-queries.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: fix
+---
+
+The tasks page no longer runs two queries whose results were never displayed, cutting wasted work on every page load and removing a source of hidden server errors

apps/webapp/app/presenters/v3/TaskListPresenter.server.ts

@@ -6,10 +6,8 @@ import {
 import { $replica } from "~/db.server";
 import { clickhouseFactory } from "~/services/clickhouse/clickhouseFactoryInstance.server";
 import {
-  type AverageDurations,
   ClickHouseEnvironmentMetricsRepository,
   type CurrentRunningStats,
-  type DailyTaskActivity,
 } from "~/services/environmentMetricsRepository.server";
 import { singleton } from "~/utils/singleton";
 import { findCurrentWorkerFromEnvironment } from "~/v3/models/workerDeployment.server";
@@ -21,8 +19,6 @@ export type TaskListItem = {
   triggerSource: TaskTriggerSource;
 };
 
-export type TaskActivity = DailyTaskActivity[string];
-
 export class TaskListPresenter {
   constructor(private readonly _replica: PrismaClientOrTransaction) {}
 
@@ -55,9 +51,7 @@ export class TaskListPresenter {
     if (!currentWorker) {
       return {
         tasks: [],
-        activity: Promise.resolve({} as DailyTaskActivity),
         runningStats: Promise.resolve({} as CurrentRunningStats),
-        durations: Promise.resolve({} as AverageDurations),
       };
     }
 
@@ -89,16 +83,10 @@ export class TaskListPresenter {
       clickhouse,
     });
 
-    // IMPORTANT: Don't await these, we want to return the promises
-    // so we can defer the loading of the data
-    const activity = environmentMetricsRepository.getDailyTaskActivity({
-      organizationId,
-      projectId,
-      environmentId,
-      days: 6, // This actually means 7 days, because we want to show the current day too
-      tasks: slugs,
-    });
-
+    // IMPORTANT: Don't await this, we want to return the promise
+    // so we can defer the loading of the data. The caller is responsible for
+    // consuming it — an unconsumed promise here would become an unhandled
+    // rejection if the underlying query fails.
     const runningStats = environmentMetricsRepository.getCurrentRunningStats({
       organizationId,
       projectId,
@@ -107,15 +95,7 @@ export class TaskListPresenter {
       tasks: slugs,
     });
 
-    const durations = environmentMetricsRepository.getAverageDurations({
-      organizationId,
-      projectId,
-      environmentId,
-      days: 6,
-      tasks: slugs,
-    });
-
-    return { tasks, activity, runningStats, durations };
+    return { tasks, runningStats };
   }
 }
 

apps/webapp/app/services/environmentMetricsRepository.server.ts

@@ -2,34 +2,16 @@ import { type ClickHouse } from "@internal/clickhouse";
 import type { TaskRunStatus } from "@trigger.dev/database";
 import { QUEUED_STATUSES } from "~/components/runs/v3/TaskRunStatus";
 
-export type DailyTaskActivity = Record<string, ({ day: string } & Record<TaskRunStatus, number>)[]>;
 export type CurrentRunningStats = Record<string, { queued: number; running: number }>;
-export type AverageDurations = Record<string, number>;
 
 export interface EnvironmentMetricsRepository {
-  getDailyTaskActivity(options: {
-    organizationId: string;
-    projectId: string;
-    environmentId: string;
-    days: number;
-    tasks: string[];
-  }): Promise<DailyTaskActivity>;
-
   getCurrentRunningStats(options: {
     organizationId: string;
     projectId: string;
     environmentId: string;
     days: number;
     tasks: string[];
   }): Promise<CurrentRunningStats>;
-
-  getAverageDurations(options: {
-    organizationId: string;
-    projectId: string;
-    environmentId: string;
-    days: number;
-    tasks: string[];
-  }): Promise<AverageDurations>;
 }
 
 export type ClickHouseEnvironmentMetricsRepositoryOptions = {
@@ -39,45 +21,6 @@ export type ClickHouseEnvironmentMetricsRepositoryOptions = {
 export class ClickHouseEnvironmentMetricsRepository implements EnvironmentMetricsRepository {
   constructor(private readonly options: ClickHouseEnvironmentMetricsRepositoryOptions) {}
 
-  public async getDailyTaskActivity({
-    organizationId,
-    projectId,
-    environmentId,
-    days,
-    tasks,
-  }: {
-    organizationId: string;
-    projectId: string;
-    environmentId: string;
-    days: number;
-    tasks: string[];
-  }): Promise<DailyTaskActivity> {
-    if (tasks.length === 0) {
-      return {};
-    }
-
-    const [queryError, activity] = await this.options.clickhouse.taskRuns.getTaskActivity({
-      organizationId,
-      projectId,
-      environmentId,
-      days,
-    });
-
-    if (queryError) {
-      throw queryError;
-    }
-
-    return fillInDailyTaskActivity(
-      activity.map((a) => ({
-        taskIdentifier: a.task_identifier,
-        status: a.status as TaskRunStatus,
-        day: new Date(a.day),
-        count: BigInt(a.count),
-      })),
-      days
-    );
-  }
-
   public async getCurrentRunningStats({
     organizationId,
     projectId,
@@ -115,82 +58,6 @@ export class ClickHouseEnvironmentMetricsRepository implements EnvironmentMetric
       tasks
     );
   }
-
-  public async getAverageDurations({
-    organizationId,
-    projectId,
-    environmentId,
-    days,
-    tasks,
-  }: {
-    organizationId: string;
-    projectId: string;
-    environmentId: string;
-    days: number;
-    tasks: string[];
-  }): Promise<AverageDurations> {
-    if (tasks.length === 0) {
-      return {};
-    }
-
-    const [queryError, durations] = await this.options.clickhouse.taskRuns.getAverageDurations({
-      organizationId,
-      projectId,
-      environmentId,
-      days,
-    });
-
-    if (queryError) {
-      throw queryError;
-    }
-
-    return Object.fromEntries(durations.map((d) => [d.task_identifier, Number(d.duration)]));
-  }
-}
-
-type TaskActivityResults = Array<{
-  taskIdentifier: string;
-  status: TaskRunStatus;
-  day: Date;
-  count: bigint;
-}>;
-
-function fillInDailyTaskActivity(activity: TaskActivityResults, days: number): DailyTaskActivity {
-  //today with no time
-  const today = new Date();
-  today.setUTCHours(0, 0, 0, 0);
-
-  return activity.reduce((acc, a) => {
-    let existingTask = acc[a.taskIdentifier];
-
-    if (!existingTask) {
-      existingTask = [];
-      //populate the array with the past 7 days
-      for (let i = days; i >= 0; i--) {
-        const day = new Date(today);
-        day.setUTCDate(today.getDate() - i);
-        day.setUTCHours(0, 0, 0, 0);
-
-        existingTask.push({
-          day: day.toISOString(),
-          ["COMPLETED_SUCCESSFULLY"]: 0,
-        } as { day: string } & Record<TaskRunStatus, number>);
-      }
-
-      acc[a.taskIdentifier] = existingTask;
-    }
-
-    const dayString = a.day.toISOString();
-    const day = existingTask.find((d) => d.day === dayString);
-
-    if (!day) {
-      return acc;
-    }
-
-    day[a.status] = Number(a.count);
-
-    return acc;
-  }, {} as DailyTaskActivity);
 }
 
 type CurrentRunningStatsResults = Array<{