fix(webapp): address review feedback on favorites and sidebar customization

Skip the locked preference transaction on the hot current-environment
save when the session snapshot already matches, so plain page loads do
no extra database work. Give favorite rename and remove their own
fetchers so quick successive mutations can't cancel each other.

Close favorite and More popovers when navigation changes only the
search string, keep the section options trigger visible while it holds
keyboard focus, and dedupe saved order ids defensively.

Author: samejr

apps/webapp/app/components/navigation/FavoritesSection.tsx

@@ -45,9 +45,10 @@ export function FavoriteMenuItem({
   const [isEditing, setIsEditing] = useState(false);
   const [isMenuOpen, setMenuOpen] = useState(false);
 
+  // Watch search too: navigating to a favorite can change only the search on the same pathname
   useEffect(() => {
     setMenuOpen(false);
-  }, [navigation.location?.pathname]);
+  }, [navigation.location?.pathname, navigation.location?.search]);
 
   const icon = favoritePageIcon(favorite.icon);
   const isActive = isFavoriteActive(favorite, location.pathname, location.search);

apps/webapp/app/components/navigation/SideMenu.tsx

@@ -406,15 +406,18 @@ export function SideMenu({
   };
   // Same ownership rule: removing a favorite optimistically unmounts its menu item (and, for the
   // last favorite, the whole section), which would abort an item-owned fetcher mid-request.
-  const favoriteActionsFetcher = useFetcher();
+  // Separate fetchers per mutation: fetchers are single-flight, so a shared one would cancel an
+  // in-flight rename when a remove follows quickly (or vice versa).
+  const removeFavoriteFetcher = useFetcher();
+  const renameFavoriteFetcher = useFetcher();
   const removeFavorite = (id: string) => {
-    favoriteActionsFetcher.submit(
+    removeFavoriteFetcher.submit(
       { intent: "remove", id },
       { method: "POST", action: FAVORITES_ACTION_PATH }
     );
   };
   const renameFavorite = (id: string, label: string) => {
-    favoriteActionsFetcher.submit(
+    renameFavoriteFetcher.submit(
       { intent: "rename", id, label },
       { method: "POST", action: FAVORITES_ACTION_PATH }
     );
@@ -1379,9 +1382,10 @@ function SideMenuMoreItem({
   const [isOpen, setOpen] = useState(false);
   const navigation = useNavigation();
 
+  // Watch search too: navigating to a favorite can change only the search on the same pathname
   useEffect(() => {
     setOpen(false);
-  }, [navigation.location?.pathname]);
+  }, [navigation.location?.pathname, navigation.location?.search]);
 
   return (
     <Popover open={isOpen} onOpenChange={setOpen}>

apps/webapp/app/components/navigation/SideMenuSection.tsx

@@ -90,7 +90,8 @@ export function SideMenuSection({
               className="absolute right-1 top-1/2 -translate-y-1/2"
               style={{ opacity: "var(--sm-label-opacity, 1)" }}
             >
-              <div className="opacity-0 has-[[data-state=open]]:opacity-100 group-hover/sectionheader:opacity-100">
+              {/* focus-within keeps the trigger visible for keyboard users tabbing onto it */}
+              <div className="opacity-0 focus-within:opacity-100 has-[[data-state=open]]:opacity-100 group-hover/sectionheader:opacity-100">
                 {headerMenu}
               </div>
             </div>

apps/webapp/app/components/navigation/sideMenuTypes.ts

@@ -41,7 +41,8 @@ export function orderByPreference<T extends { id: string }>(
   if (!savedOrder || savedOrder.length === 0) return entries;
 
   const defaultIndex = new Map(entries.map((entry, index) => [entry.id, index]));
-  const orderedIds = savedOrder.filter((id) => defaultIndex.has(id));
+  // Set-dedupe: a corrupted saved order with duplicate ids must not render an entry twice
+  const orderedIds = [...new Set(savedOrder.filter((id) => defaultIndex.has(id)))];
   const missingIds = entries.map((entry) => entry.id).filter((id) => !orderedIds.includes(id));
 
   for (const id of missingIds) {

apps/webapp/app/services/dashboardPreferences.server.ts

@@ -130,6 +130,16 @@ export async function updateCurrentProjectEnvironmentId({
     return;
   }
 
+  // Fast path: this runs on nearly every navigation (env layout loader), so skip the locked
+  // transaction when the session snapshot already matches. The in-transaction check below stays
+  // authoritative for the rare stale-snapshot case.
+  if (
+    user.dashboardPreferences.currentProjectId === projectId &&
+    user.dashboardPreferences.projects[projectId]?.currentEnvironment?.id === environmentId
+  ) {
+    return;
+  }
+
   return mutateDashboardPreferences(user.id, (prefs) => {
     //only update if the existing preferences are different
     if (