refactor(run-engine): share the queued snapshot status and description

The trigger path writes this snapshot nested in the run create and emits the
timeline event itself, while every re-enqueue writes it through enqueueRun.
Keep the status and the default description in one place so the persisted row
and the emitted event cannot drift apart.

Author: ericallam

.server-changes/collapse-trigger-queued-snapshot.md

@@ -3,4 +3,4 @@ area: webapp
 type: improvement
 ---
 
-Triggering a task now reaches the queue marginally faster.
+Triggering a task now does one fewer database write, so runs reach the queue slightly faster.

internal-packages/run-engine/src/engine/consts.ts

@@ -1 +1,11 @@
 export const MAX_TASK_RUN_ATTEMPTS = 250;
+
+/**
+ * The status and description a run's default entry into the queue is written with. Shared because
+ * the trigger path writes this snapshot nested in the run-create transaction and then emits its own
+ * `executionSnapshotCreated`, while every re-enqueue writes it through `enqueueRun`. Three places
+ * have to agree, or the persisted row and the run timeline's `[engine]` entry drift apart.
+ * Re-enqueues that describe why they requeued pass their own description instead.
+ */
+export const QUEUED_SNAPSHOT_STATUS = "QUEUED" as const;
+export const QUEUED_SNAPSHOT_DESCRIPTION = "Run was QUEUED";

internal-packages/run-engine/src/engine/index.ts

@@ -54,6 +54,7 @@ import { RunQueue } from "../run-queue/index.js";
 import { RunQueueFullKeyProducer } from "../run-queue/keyProducer.js";
 import type { AuthenticatedEnvironment, MinimalAuthenticatedEnvironment } from "../shared/index.js";
 import { BillingCache } from "./billingCache.js";
+import { QUEUED_SNAPSHOT_DESCRIPTION, QUEUED_SNAPSHOT_STATUS } from "./consts.js";
 import {
   ExecutionSnapshotNotFoundError,
   NotImplementedError,
@@ -1036,8 +1037,8 @@ export class RunEngine {
               snapshot: {
                 id: initialSnapshotId,
                 engine: "V2",
-                executionStatus: delayUntil ? "DELAYED" : "QUEUED",
-                description: delayUntil ? "Run is delayed" : "Run was QUEUED",
+                executionStatus: delayUntil ? "DELAYED" : QUEUED_SNAPSHOT_STATUS,
+                description: delayUntil ? "Run is delayed" : QUEUED_SNAPSHOT_DESCRIPTION,
                 runStatus: status,
                 environmentId: environment.id,
                 environmentType: environment.type,
@@ -1171,8 +1172,8 @@ export class RunEngine {
               },
               snapshot: {
                 id: initialSnapshotId,
-                executionStatus: "QUEUED",
-                description: "Run was QUEUED",
+                executionStatus: QUEUED_SNAPSHOT_STATUS,
+                description: QUEUED_SNAPSHOT_DESCRIPTION,
                 runStatus: taskRun.status,
                 attemptNumber: taskRun.attemptNumber ?? null,
                 checkpointId: null,

internal-packages/run-engine/src/engine/systems/enqueueSystem.ts

@@ -7,6 +7,7 @@ import type {
 import type { RunStore } from "@internal/run-store";
 import { parseNaturalLanguageDuration } from "@trigger.dev/core/v3/isomorphic";
 import type { MinimalAuthenticatedEnvironment } from "../../shared/index.js";
+import { QUEUED_SNAPSHOT_DESCRIPTION, QUEUED_SNAPSHOT_STATUS } from "../consts.js";
 import type { ExecutionSnapshotSystem } from "./executionSnapshotSystem.js";
 import type { SystemResources } from "./systems.js";
 
@@ -95,8 +96,8 @@ export class EnqueueSystem {
         {
           run: run,
           snapshot: {
-            executionStatus: snapshot?.status ?? "QUEUED",
-            description: snapshot?.description ?? "Run was QUEUED",
+            executionStatus: snapshot?.status ?? QUEUED_SNAPSHOT_STATUS,
+            description: snapshot?.description ?? QUEUED_SNAPSHOT_DESCRIPTION,
             metadata: snapshot?.metadata ?? undefined,
           },
           previousSnapshotId,