fix(dashboard-agent-db): require a role on the messages the append-once queries accept

Author: kathiekiwi

apps/webapp/test/dashboardAgentTranscriptStore.test.ts

@@ -75,6 +75,13 @@ function textMessage(id: string, text = id) {
   return { id, role: "assistant" as const, parts: [{ type: "text", text }] };
 }
 
+// Compile-time: the insert reads `role` off the body and throws without one, so a
+// message that satisfies the signature must never be able to lack it.
+() => {
+  // @ts-expect-error a message with no role is not appendable
+  void appendChatMessageOnceByChatId(agentDb, { chatId: "chat_x", message: { id: "m1" } });
+};
+
 function toolMessage(id: string, state: "input-available" | "output-available") {
   return {
     id,

internal-packages/dashboard-agent-db/src/queries.ts

@@ -545,7 +545,7 @@ export async function appendChatMessageOnce(
     chatId: string;
     userId: string;
     organizationId?: string;
-    message: { id: string };
+    message: { id: string; role: string };
   }
 ): Promise<boolean> {
   return appendOneMessage(db, {
@@ -564,7 +564,7 @@ export async function appendChatMessageOnce(
  */
 export async function appendChatMessageOnceByChatId(
   db: DashboardAgentDbOrTx,
-  params: { chatId: string; message: { id: string } }
+  params: { chatId: string; message: { id: string; role: string } }
 ): Promise<boolean> {
   return appendOneMessage(db, { chatId: params.chatId, message: params.message, scope: [] });
 }