Commit 09f4083
committed
feat(webapp): CI guard for unindexed onDelete cascade FK columns
A relation with onDelete Cascade/SetNull whose child FK column has no index
makes every parent delete fire a cascade that sequentially scans the whole
child table. This shipped three times recently (ProjectAlert.channelId,
EnvironmentVariableValue.valueReferenceId, PersonalAccessToken.userId).
Adds a schema-aware guard (modeled on runOpsLegacyGuard) that parses both
Prisma schemas and flags any cascade/SetNull FK whose leading scalar is not
the leading column of an index. Whether a missing index is a live bug depends
on whether the parent is hard- or soft-deleted, which is not in the schema, so
the guard carries a baseline of the 72 currently-accepted cases and only fails
--check on new un-baselined violations. Wired into pr_checks as fk-cascade-guard.1 parent c4b5e27 commit 09f4083
5 files changed
Lines changed: 754 additions & 0 deletions
File tree
- .github/workflows
- apps/webapp
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| |||
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
153 | 159 | | |
154 | 160 | | |
155 | 161 | | |
| |||
206 | 212 | | |
207 | 213 | | |
208 | 214 | | |
| 215 | + | |
209 | 216 | | |
210 | 217 | | |
211 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
0 commit comments