From 0cb73c63e03d0a2ad572e17d3c45b0193edc3b27 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Thu, 30 Jul 2026 18:22:35 +0200 Subject: [PATCH 01/40] Test Gyselalibxx --- .github/workflows/spack.yaml | 32 ++++++++----------- gyselalibxx.yaml | 60 ++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 19 deletions(-) create mode 100644 gyselalibxx.yaml diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index e0e4582..141077c 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -6,6 +6,7 @@ on: push: branches: - main + pull_request: workflow_dispatch: permissions: @@ -17,17 +18,7 @@ jobs: fail-fast: false matrix: env: - - dev-benchmark-euler-kernels.yaml - - dev-ddc.yaml - - dev-gmgpolar.yaml - - dev-gyselalibxx.yaml - - dev-gyselaxpp.yaml - - dev-heraclespp.yaml - - dev-kokkos.yaml - - dev-kokkos-comm.yaml - - dev-kokkos-fft.yaml - - dev-mini-app-io.yaml - - dev-mini-app-poisson.yaml + - gyselalibxx.yaml os: [ubuntu-26.04] runs-on: ${{matrix.os}} permissions: @@ -56,11 +47,14 @@ jobs: spack --env . concretize mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --fail-fast --include-build-deps --show-log-on-error - - name: Push packages and update index - shell: spack-bash {0} - env: - GITHUB_USER: ${{github.actor}} - GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - run: spack --env . buildcache push --fail-fast --update-index local-buildcache - if: ${{!cancelled()}} + spack --env . install --test root --include-build-deps --show-log-on-error + # - name: Push packages and update index + # shell: spack-bash {0} + # env: + # GITHUB_USER: ${{github.actor}} + # GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + # run: spack --env . buildcache push --fail-fast --update-index local-buildcache + # if: ${{!cancelled()}} + - name: Setup tmate session + if: ${{ failure() }} + uses: mxschmitt/action-tmate@v3 diff --git a/gyselalibxx.yaml b/gyselalibxx.yaml new file mode 100644 index 0000000..b6ddcd7 --- /dev/null +++ b/gyselalibxx.yaml @@ -0,0 +1,60 @@ +--- +spack: + concretizer: + reuse: false + unify: true + config: + sandbox: + enable: true + allow_network: false + allow_read: + - / + allow_write: + - /home/runner + - /dev + mirrors: + local-buildcache: + url: oci://ghcr.io/tpadioleau/dev-spack-ubuntu-26.04 + binary: true + signed: false + access_pair: + id_variable: GITHUB_USER + secret_variable: GITHUB_TOKEN + packages: + all: + require: + - 'target=x86_64' + prefer: + - '~cuda' + - '~rocm' + - '~openmp' + - '~mpi' + - '~fortran' + c: + require: 'gcc@15.2' + cxx: + require: 'gcc@15.2' + fortran: + require: 'gcc@15.2' + py-dask: + prefer: + - '~dataframe' + py-pandas: + prefer: + - '~performance' + freetype: + prefer: + - '@2.14.1' + repos: + patches: + git: https://github.com/gyselax/spack.git + branch: releases/v2026.06-debug + builtin: + branch: releases/v2026.06 + specs: + - 'gyselalibxx' + view: + default: + projections: + all: "{name}-{version}-{hash}" + root: .spack-env/view From de2a1efbec05898bdfa58ee840a06c8396357d8f Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Fri, 31 Jul 2026 14:17:19 +0200 Subject: [PATCH 02/40] Give a try to openshmem --- gyselalibxx.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gyselalibxx.yaml b/gyselalibxx.yaml index b6ddcd7..6efc8d7 100644 --- a/gyselalibxx.yaml +++ b/gyselalibxx.yaml @@ -45,6 +45,9 @@ spack: freetype: prefer: - '@2.14.1' + openmpi: + prefer: + - '+openshmem' repos: patches: git: https://github.com/gyselax/spack.git From b200e4bd85b44cb78678762ff8e6fa3e4b007beb Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 1 Aug 2026 09:30:06 +0200 Subject: [PATCH 03/40] Update --- .github/workflows/spack.yaml | 3 ++- gyselalibxx.yaml => gysela.yaml | 15 ++------------- 2 files changed, 4 insertions(+), 14 deletions(-) rename gyselalibxx.yaml => gysela.yaml (79%) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 141077c..9cfdef6 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -18,7 +18,7 @@ jobs: fail-fast: false matrix: env: - - gyselalibxx.yaml + - gysela.yaml os: [ubuntu-26.04] runs-on: ${{matrix.os}} permissions: @@ -58,3 +58,4 @@ jobs: - name: Setup tmate session if: ${{ failure() }} uses: mxschmitt/action-tmate@v3 + timeout-minutes: 30 diff --git a/gyselalibxx.yaml b/gysela.yaml similarity index 79% rename from gyselalibxx.yaml rename to gysela.yaml index 6efc8d7..f12c160 100644 --- a/gyselalibxx.yaml +++ b/gysela.yaml @@ -3,15 +3,6 @@ spack: concretizer: reuse: false unify: true - config: - sandbox: - enable: true - allow_network: false - allow_read: - - / - allow_write: - - /home/runner - - /dev mirrors: local-buildcache: url: oci://ghcr.io/tpadioleau/dev-spack-ubuntu-26.04 @@ -45,17 +36,15 @@ spack: freetype: prefer: - '@2.14.1' - openmpi: - prefer: - - '+openshmem' repos: patches: git: https://github.com/gyselax/spack.git - branch: releases/v2026.06-debug + branch: releases/v2026.06 builtin: branch: releases/v2026.06 specs: - 'gyselalibxx' + - 'gysela-mini-app-io' view: default: projections: From dbeea61a303073c6270cad6b4ca8d085abaeed15 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 1 Aug 2026 14:53:15 +0200 Subject: [PATCH 04/40] Go to develop branch --- gysela.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gysela.yaml b/gysela.yaml index f12c160..b147919 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -33,15 +33,12 @@ spack: py-pandas: prefer: - '~performance' - freetype: - prefer: - - '@2.14.1' repos: patches: git: https://github.com/gyselax/spack.git branch: releases/v2026.06 builtin: - branch: releases/v2026.06 + branch: develop specs: - 'gyselalibxx' - 'gysela-mini-app-io' From 242c09a10592a1d6db41e52e02ef8fe837f3883e Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 1 Aug 2026 16:39:58 +0200 Subject: [PATCH 05/40] Test root --- .github/workflows/spack.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 9cfdef6..40ad4ed 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -44,10 +44,10 @@ jobs: - name: Install shell: spack-bash {0} run: | - spack --env . concretize + spack --env . concretize --test root mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --test root --include-build-deps --show-log-on-error + spack --env . install --include-build-deps --show-log-on-error # - name: Push packages and update index # shell: spack-bash {0} # env: From 3120dbe452f501cc4d9e028ac671c37f727d0dc4 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 1 Aug 2026 16:40:43 +0200 Subject: [PATCH 06/40] Fail fast --- .github/workflows/spack.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 40ad4ed..1dc981c 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -47,7 +47,7 @@ jobs: spack --env . concretize --test root mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --include-build-deps --show-log-on-error + spack --env . install --fail-fast --include-build-deps --show-log-on-error # - name: Push packages and update index # shell: spack-bash {0} # env: From 07f188452ab3a14d3c8512b9b448530c372855ed Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 3 Aug 2026 22:44:33 +0200 Subject: [PATCH 07/40] Add more packages to test --- gysela.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index b147919..9f00df6 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -5,7 +5,7 @@ spack: unify: true mirrors: local-buildcache: - url: oci://ghcr.io/tpadioleau/dev-spack-ubuntu-26.04 + url: oci://ghcr.io/tpadioleau/develop-ubuntu-26.04 binary: true signed: false access_pair: @@ -40,6 +40,9 @@ spack: builtin: branch: develop specs: + - 'kokkos +tests' + - 'kokkos-fft +tests' + - 'ddc' - 'gyselalibxx' - 'gysela-mini-app-io' view: From 3d61e3c6219c04bd0ed3ef474b8825516d44072d Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 3 Aug 2026 22:50:47 +0200 Subject: [PATCH 08/40] Push on a new binary cache --- .github/workflows/spack.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 1dc981c..c59da4f 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -48,13 +48,13 @@ jobs: mkdir tmp_spack export TMPDIR=$PWD/tmp_spack spack --env . install --fail-fast --include-build-deps --show-log-on-error - # - name: Push packages and update index - # shell: spack-bash {0} - # env: - # GITHUB_USER: ${{github.actor}} - # GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - # run: spack --env . buildcache push --fail-fast --update-index local-buildcache - # if: ${{!cancelled()}} + - name: Push packages and update index + shell: spack-bash {0} + env: + GITHUB_USER: ${{github.actor}} + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + run: spack --env . buildcache push --fail-fast --update-index local-buildcache + if: ${{!cancelled()}} - name: Setup tmate session if: ${{ failure() }} uses: mxschmitt/action-tmate@v3 From d2d299d4831306286120624575105a6f0ae6524b Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 4 Aug 2026 08:29:54 +0200 Subject: [PATCH 09/40] Add test root to install command --- .github/workflows/spack.yaml | 2 +- gysela.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index c59da4f..2689876 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -47,7 +47,7 @@ jobs: spack --env . concretize --test root mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --fail-fast --include-build-deps --show-log-on-error + spack --env . install --test root --fail-fast --include-build-deps --show-log-on-error - name: Push packages and update index shell: spack-bash {0} env: diff --git a/gysela.yaml b/gysela.yaml index 9f00df6..c69bc08 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -31,7 +31,7 @@ spack: prefer: - '~dataframe' py-pandas: - prefer: + prefer: - '~performance' repos: patches: From 9386d8ab3cd34587ada5e275f9c61b713d9fbe92 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Thu, 6 Aug 2026 20:49:58 +0200 Subject: [PATCH 10/40] Remove +tests from kokkos-fft --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index c69bc08..618b0a2 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -41,7 +41,7 @@ spack: branch: develop specs: - 'kokkos +tests' - - 'kokkos-fft +tests' + - 'kokkos-fft' - 'ddc' - 'gyselalibxx' - 'gysela-mini-app-io' From fe3c537cf258f5666c301b047bb8d24987b397db Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Fri, 7 Aug 2026 08:43:30 +0200 Subject: [PATCH 11/40] Also test Kokkos Kernels --- gysela.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/gysela.yaml b/gysela.yaml index 618b0a2..c849e61 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -42,6 +42,7 @@ spack: specs: - 'kokkos +tests' - 'kokkos-fft' + - 'kokkos-kernels +execspace_serial' - 'ddc' - 'gyselalibxx' - 'gysela-mini-app-io' From dcc64b5ee998d902c9c49569491facaa8910213f Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Fri, 7 Aug 2026 21:27:21 +0200 Subject: [PATCH 12/40] Also test ginkgo --- gysela.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/gysela.yaml b/gysela.yaml index c849e61..32d26f8 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -44,6 +44,7 @@ spack: - 'kokkos-fft' - 'kokkos-kernels +execspace_serial' - 'ddc' + - 'ginkgo' - 'gyselalibxx' - 'gysela-mini-app-io' view: From 9310a8e3675bfe167ae6027b4fa7993dc45da35b Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 10 Aug 2026 09:20:05 +0200 Subject: [PATCH 13/40] Add gmgpolar --- gysela.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gysela.yaml b/gysela.yaml index 32d26f8..8c5474e 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -3,6 +3,15 @@ spack: concretizer: reuse: false unify: true + config: + sandbox: + enable: true + allow_network: true + allow_read: + - / + allow_write: + - /home/runner + - /dev mirrors: local-buildcache: url: oci://ghcr.io/tpadioleau/develop-ubuntu-26.04 @@ -45,6 +54,7 @@ spack: - 'kokkos-kernels +execspace_serial' - 'ddc' - 'ginkgo' + - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' view: From b6c38e7b5be1fc1349441f1290cf3b4ba824f7ea Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 11 Aug 2026 10:41:26 +0200 Subject: [PATCH 14/40] More packages --- gysela.yaml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gysela.yaml b/gysela.yaml index 8c5474e..9289a1f 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -47,9 +47,10 @@ spack: git: https://github.com/gyselax/spack.git branch: releases/v2026.06 builtin: - branch: develop + git: https://github.com/tpadioleau/spack-packages.git + branch: test-all-packages specs: - - 'kokkos +tests' + - 'kokkos' - 'kokkos-fft' - 'kokkos-kernels +execspace_serial' - 'ddc' @@ -57,6 +58,15 @@ spack: - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' + - 'paraconf' + - 'pdi' + - 'pdiplugin-decl-netcdf' + - 'pdiplugin-mpi' + - 'pdiplugin-pycall' + - 'pdiplugin-serialize' + - 'pdiplugin-set-value' + - 'pdiplugin-trace' + - 'pdiplugin-user-code' view: default: projections: From 7ea9db1b566098e4cad22c8158fada4854e29beb Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 11 Aug 2026 10:52:01 +0200 Subject: [PATCH 15/40] Fix repos --- gysela.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index 9289a1f..c373795 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -46,9 +46,11 @@ spack: patches: git: https://github.com/gyselax/spack.git branch: releases/v2026.06 - builtin: + tpadioleau-builtin: git: https://github.com/tpadioleau/spack-packages.git branch: test-all-packages + builtin: + branch: develop specs: - 'kokkos' - 'kokkos-fft' From 48b32cd588d9914df4fd8223d38f15d087ddbb2f Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 11 Aug 2026 19:04:14 +0200 Subject: [PATCH 16/40] Add mdspan --- gysela.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/gysela.yaml b/gysela.yaml index c373795..3715b96 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -60,6 +60,7 @@ spack: - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' + - 'mdspan' - 'paraconf' - 'pdi' - 'pdiplugin-decl-netcdf' From 85384bf1bb5d0578c9b2d21b1215cf125614b53a Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 11 Aug 2026 20:29:37 +0200 Subject: [PATCH 17/40] Fix mdspan and add kokkos tools --- gysela.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index 3715b96..d785196 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -54,13 +54,14 @@ spack: specs: - 'kokkos' - 'kokkos-fft' + - 'kokkos-tools' - 'kokkos-kernels +execspace_serial' - 'ddc' - 'ginkgo' - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' - - 'mdspan' + - 'mdspan@stable' - 'paraconf' - 'pdi' - 'pdiplugin-decl-netcdf' From 25aab32e0cf1bcee877cec0e64cc2f3da23cde90 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Wed, 12 Aug 2026 14:32:42 +0200 Subject: [PATCH 18/40] Add py-numpy --- gysela.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/gysela.yaml b/gysela.yaml index d785196..59a2214 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -71,6 +71,7 @@ spack: - 'pdiplugin-set-value' - 'pdiplugin-trace' - 'pdiplugin-user-code' + - 'py-numpy' view: default: projections: From f97e0647f09f7ecdb9829f527584e16370f4207e Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Wed, 12 Aug 2026 14:34:12 +0200 Subject: [PATCH 19/40] Keep problematic packages --- gysela.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gysela.yaml b/gysela.yaml index 59a2214..e6515b3 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -55,15 +55,18 @@ spack: - 'kokkos' - 'kokkos-fft' - 'kokkos-tools' + # - 'kokkos-kernels', some tests do not link without some ETI - 'kokkos-kernels +execspace_serial' - 'ddc' - 'ginkgo' - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' + # - 'mdspan', no releases - 'mdspan@stable' - 'paraconf' - 'pdi' + # - 'pdiplugin-decl-hdf5', some MPI tests require too many processes - 'pdiplugin-decl-netcdf' - 'pdiplugin-mpi' - 'pdiplugin-pycall' From d09cfab1f0fb0ea195278f51f3197f9e7cdadcb7 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Wed, 12 Aug 2026 14:45:29 +0200 Subject: [PATCH 20/40] Remove py-numpy --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index e6515b3..8f94c7f 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -74,7 +74,7 @@ spack: - 'pdiplugin-set-value' - 'pdiplugin-trace' - 'pdiplugin-user-code' - - 'py-numpy' + # - 'py-numpy', error: ModuleNotFoundError: No module named 'numpy' view: default: projections: From 30e348a3970dba606e49c5d199cc00f55cb2fe85 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Wed, 12 Aug 2026 14:45:49 +0200 Subject: [PATCH 21/40] Remove tmate --- .github/workflows/spack.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 2689876..eae195a 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -55,7 +55,3 @@ jobs: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} run: spack --env . buildcache push --fail-fast --update-index local-buildcache if: ${{!cancelled()}} - - name: Setup tmate session - if: ${{ failure() }} - uses: mxschmitt/action-tmate@v3 - timeout-minutes: 30 From bd28628933e7c2ffe4ec254ebcb205b4f7593e5b Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Thu, 13 Aug 2026 12:14:04 +0200 Subject: [PATCH 22/40] Add hdf5 and netcdf --- gysela.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gysela.yaml b/gysela.yaml index 8f94c7f..138cad4 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -62,8 +62,10 @@ spack: - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' + - 'hdf5 +mpi +shared' # - 'mdspan', no releases - 'mdspan@stable' + - 'netcdf-c' - 'paraconf' - 'pdi' # - 'pdiplugin-decl-hdf5', some MPI tests require too many processes From afb3839e48ac722e99e72c8929335479ebb129dc Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Thu, 13 Aug 2026 18:50:00 +0200 Subject: [PATCH 23/40] Reorder --- gysela.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/gysela.yaml b/gysela.yaml index 138cad4..9baaad9 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -52,17 +52,18 @@ spack: builtin: branch: develop specs: - - 'kokkos' - - 'kokkos-fft' - - 'kokkos-tools' - # - 'kokkos-kernels', some tests do not link without some ETI - - 'kokkos-kernels +execspace_serial' - 'ddc' - 'ginkgo' - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' - 'hdf5 +mpi +shared' + - 'kokkos' + - 'kokkos-fft' + - 'kokkos-tools' + # - 'kokkos-kernels', some tests do not link without some ETI + - 'kokkos-kernels +execspace_serial' + # - 'koliop', tests consume too much memory # - 'mdspan', no releases - 'mdspan@stable' - 'netcdf-c' From bc58e0da9b0b8a780cae8ab81975791e97abb7bb Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Fri, 14 Aug 2026 14:49:54 +0200 Subject: [PATCH 24/40] Add openblas --- gysela.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/gysela.yaml b/gysela.yaml index 9baaad9..1c39331 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -67,6 +67,7 @@ spack: # - 'mdspan', no releases - 'mdspan@stable' - 'netcdf-c' + - 'openblas' - 'paraconf' - 'pdi' # - 'pdiplugin-decl-hdf5', some MPI tests require too many processes From 43fc47008f75d8c948e80252ffd6a8c09ab997ba Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 15 Aug 2026 09:20:40 +0200 Subject: [PATCH 25/40] Add a tag --- .github/workflows/spack.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index eae195a..55b1e47 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -53,5 +53,5 @@ jobs: env: GITHUB_USER: ${{github.actor}} GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - run: spack --env . buildcache push --fail-fast --update-index local-buildcache + run: spack --env . buildcache push --fail-fast --tag latest --update-index local-buildcache if: ${{!cancelled()}} From 89d404e388c0945f6235f975b664eadb505a132e Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 15 Aug 2026 16:04:02 +0200 Subject: [PATCH 26/40] Test --- .github/workflows/spack.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 55b1e47..a56c35e 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -32,7 +32,7 @@ jobs: uses: spack/setup-spack@16b756799ede8b28951287f89bcd3fdb32ec1ca3 # v3.0.0 with: spack_ref: v1.2.2 - buildcache: true + buildcache: false - name: Prepare environment shell: spack-bash {0} run: | From 71d51c33dfef50dc10d35c4f43ffef369ddbf5cd Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 24 Aug 2026 06:57:51 +0200 Subject: [PATCH 27/40] Add spdlog and fmt --- gysela.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gysela.yaml b/gysela.yaml index 1c39331..a0b6e71 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -53,6 +53,7 @@ spack: branch: develop specs: - 'ddc' + - 'fmt' - 'ginkgo' - 'gmgpolar' - 'gyselalibxx' @@ -79,6 +80,7 @@ spack: - 'pdiplugin-trace' - 'pdiplugin-user-code' # - 'py-numpy', error: ModuleNotFoundError: No module named 'numpy' + - 'spdlog' view: default: projections: From 5c26d5cce8f25603083145bf46cba51f99304946 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 29 Aug 2026 14:48:31 +0200 Subject: [PATCH 28/40] Test pdiplugin-decl-hdf5 --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index a0b6e71..fcb2b7b 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -71,7 +71,7 @@ spack: - 'openblas' - 'paraconf' - 'pdi' - # - 'pdiplugin-decl-hdf5', some MPI tests require too many processes + - 'pdiplugin-decl-hdf5' - 'pdiplugin-decl-netcdf' - 'pdiplugin-mpi' - 'pdiplugin-pycall' From 842f1889cd513d771d48f8778730093a9f04a342 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 1 Sep 2026 14:57:12 +0200 Subject: [PATCH 29/40] Retest koliop --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index fcb2b7b..fe612d3 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -64,7 +64,7 @@ spack: - 'kokkos-tools' # - 'kokkos-kernels', some tests do not link without some ETI - 'kokkos-kernels +execspace_serial' - # - 'koliop', tests consume too much memory + - 'koliop' # - 'mdspan', no releases - 'mdspan@stable' - 'netcdf-c' From be3cc61326d69f99a3d6e0adf961430fb6c1cccb Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sun, 13 Sep 2026 20:12:05 +0200 Subject: [PATCH 30/40] Add autopush and use develop branch --- .github/workflows/spack.yaml | 4 ++++ gysela.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index a56c35e..9eb90f4 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -41,8 +41,12 @@ jobs: spack --env . config add config:install_tree:padded_length:128 spack --env . repo update spack --env . buildcache list + spack --env . mirror set --autopush local-buildcache - name: Install shell: spack-bash {0} + env: + GITHUB_USER: ${{github.actor}} + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} run: | spack --env . concretize --test root mkdir tmp_spack diff --git a/gysela.yaml b/gysela.yaml index fe612d3..65ee1d4 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -45,7 +45,7 @@ spack: repos: patches: git: https://github.com/gyselax/spack.git - branch: releases/v2026.06 + branch: develop tpadioleau-builtin: git: https://github.com/tpadioleau/spack-packages.git branch: test-all-packages From 321b04ac8800a2996a0de7fab3849f33d2e3d998 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 14 Sep 2026 10:33:59 +0200 Subject: [PATCH 31/40] Add tmate --- .github/workflows/spack.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 9eb90f4..7b29933 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -52,6 +52,8 @@ jobs: mkdir tmp_spack export TMPDIR=$PWD/tmp_spack spack --env . install --test root --fail-fast --include-build-deps --show-log-on-error + - name: Setup tmate session + uses: mxschmitt/action-tmate@v3 - name: Push packages and update index shell: spack-bash {0} env: From 09b487fab52078b95d1291a576a3970fba641e39 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 14 Sep 2026 11:07:40 +0200 Subject: [PATCH 32/40] add if failure --- .github/workflows/spack.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 7b29933..6bae457 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -53,6 +53,7 @@ jobs: export TMPDIR=$PWD/tmp_spack spack --env . install --test root --fail-fast --include-build-deps --show-log-on-error - name: Setup tmate session + if: ${{ failure() }} uses: mxschmitt/action-tmate@v3 - name: Push packages and update index shell: spack-bash {0} From 5343c0da40bb67a4291078f5f27471f5418539e8 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 14 Sep 2026 18:28:50 +0200 Subject: [PATCH 33/40] Prefer upterm --- .github/workflows/spack.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 6bae457..e2ff596 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -52,9 +52,11 @@ jobs: mkdir tmp_spack export TMPDIR=$PWD/tmp_spack spack --env . install --test root --fail-fast --include-build-deps --show-log-on-error - - name: Setup tmate session + - name: Setup upterm session if: ${{ failure() }} - uses: mxschmitt/action-tmate@v3 + uses: owenthereal/action-upterm@v1 + with: + limit-access-to-actor: true # Restrict to the user who triggered the workflow - name: Push packages and update index shell: spack-bash {0} env: From 78cc4f001a701bfc9306f3f9b4b0adc23ff5e6cc Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 14 Sep 2026 18:59:53 +0200 Subject: [PATCH 34/40] Remove GMGPolar for now --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index 65ee1d4..a5a55ff 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -55,7 +55,7 @@ spack: - 'ddc' - 'fmt' - 'ginkgo' - - 'gmgpolar' + # - 'gmgpolar', SerialDirectSolverTest_CircularGeometry.DirectSolverAcrossOriginHigherPrecision2_CircularGeometry tolerance failure - 'gyselalibxx' - 'gysela-mini-app-io' - 'hdf5 +mpi +shared' From 51cfd3a2118bc77e3a4fd6c80fea528f78ba7a5f Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 14 Sep 2026 19:28:10 +0200 Subject: [PATCH 35/40] Remove kokkos kernels --- gysela.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gysela.yaml b/gysela.yaml index a5a55ff..452c4c8 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -63,7 +63,7 @@ spack: - 'kokkos-fft' - 'kokkos-tools' # - 'kokkos-kernels', some tests do not link without some ETI - - 'kokkos-kernels +execspace_serial' + # - 'kokkos-kernels +execspace_serial', serial.sparse_spmv_sell_double_int_size_t_TestDevice tolerance failure - 'koliop' # - 'mdspan', no releases - 'mdspan@stable' From 6b889e0c2c9dee897d6facbbb0a2050fbc1fec39 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Tue, 6 Oct 2026 07:57:04 +0200 Subject: [PATCH 36/40] Remove testing --- .github/workflows/spack.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index e2ff596..9738a54 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -48,10 +48,10 @@ jobs: GITHUB_USER: ${{github.actor}} GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} run: | - spack --env . concretize --test root + spack --env . concretize mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --test root --fail-fast --include-build-deps --show-log-on-error + spack --env . install --fail-fast --include-build-deps --show-log-on-error - name: Setup upterm session if: ${{ failure() }} uses: owenthereal/action-upterm@v1 From 30c82219d513dc88baaec9ed7a9da3ad8ab5dab7 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sun, 25 Oct 2026 10:39:47 +0100 Subject: [PATCH 37/40] Enable testing with a modified spack --- .github/workflows/spack.yaml | 18 +- all-test-failures.patch | 480 +++++++++++++++++++++++++++++++++++ gysela.yaml | 6 +- 3 files changed, 493 insertions(+), 11 deletions(-) create mode 100644 all-test-failures.patch diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index 9738a54..e80fbc6 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -33,6 +33,9 @@ jobs: with: spack_ref: v1.2.2 buildcache: false + - run: | + cp all-test-failures.patch ./spack/ + git -C ./spack apply all-test-failures.patch - name: Prepare environment shell: spack-bash {0} run: | @@ -40,7 +43,6 @@ jobs: spack env create . ${{matrix.env}} spack --env . config add config:install_tree:padded_length:128 spack --env . repo update - spack --env . buildcache list spack --env . mirror set --autopush local-buildcache - name: Install shell: spack-bash {0} @@ -48,15 +50,15 @@ jobs: GITHUB_USER: ${{github.actor}} GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} run: | - spack --env . concretize + spack --env . concretize --test root mkdir tmp_spack export TMPDIR=$PWD/tmp_spack - spack --env . install --fail-fast --include-build-deps --show-log-on-error - - name: Setup upterm session - if: ${{ failure() }} - uses: owenthereal/action-upterm@v1 - with: - limit-access-to-actor: true # Restrict to the user who triggered the workflow + spack --env . install --test root --allow-test-failures --fail-fast --include-build-deps --show-log-on-error + # - name: Setup upterm session + # if: ${{ failure() }} + # uses: owenthereal/action-upterm@v1 + # with: + # limit-access-to-actor: true # Restrict to the user who triggered the workflow - name: Push packages and update index shell: spack-bash {0} env: diff --git a/all-test-failures.patch b/all-test-failures.patch new file mode 100644 index 0000000..d3f6924 --- /dev/null +++ b/all-test-failures.patch @@ -0,0 +1,480 @@ +diff --git a/lib/spack/spack/builder.py b/lib/spack/spack/builder.py +index 35a3564..b95ed44 100644 +--- a/lib/spack/spack/builder.py ++++ b/lib/spack/spack/builder.py +@@ -138,6 +138,9 @@ def __init__(self, wrapped_pkg_object, root_builder): + { + "__module__": package_cls.__module__, + "run_tests": property(lambda x: x.wrapped_package_object.run_tests), ++ "allow_test_failures": property( ++ lambda x: x.wrapped_package_object.allow_test_failures ++ ), + "test_requires_compiler": property( + lambda x: x.wrapped_package_object.test_requires_compiler + ), +diff --git a/lib/spack/spack/cmd/install.py b/lib/spack/spack/cmd/install.py +index 959cc44..d789486 100644 +--- a/lib/spack/spack/cmd/install.py ++++ b/lib/spack/spack/cmd/install.py +@@ -50,6 +50,7 @@ def install_kwargs_from_args(args): + + return { + "fail_fast": args.fail_fast, ++ "allow_test_failures": args.allow_test_failures, + "keep_prefix": args.keep_prefix, + "keep_stage": args.keep_stage, + "restage": not args.dont_restage, +@@ -216,6 +217,13 @@ def setup_parser(subparser: argparse.ArgumentParser) -> None: + choices=["root", "all"], + help="run tests on only root packages or all packages", + ) ++ subparser.add_argument( ++ "--allow-test-failures", ++ action="store_true", ++ default=False, ++ help="with --test, report failing install-time tests as warnings instead of failing " ++ "the installation", ++ ) + arguments.add_common_arguments(subparser, ["log_format"]) + subparser.add_argument("--log-file", default=None, help="filename for the log file") + subparser.add_argument( +diff --git a/lib/spack/spack/install_test.py b/lib/spack/spack/install_test.py +index 5cc5426..405da49 100644 +--- a/lib/spack/spack/install_test.py ++++ b/lib/spack/spack/install_test.py +@@ -360,6 +360,7 @@ def phase_tests(self, builder, phase_name: str, method_names: List[str]): + """ + verbose = tty.is_verbose() + fail_fast = spack.config.get("config:fail_fast", False) ++ allow_failures = bool(getattr(builder.pkg, "allow_test_failures", False)) + + with self.test_logger(verbose=verbose, externals=False) as logger: + # Report running each of the methods in the build log +@@ -382,14 +383,38 @@ def phase_tests(self, builder, phase_name: str, method_names: List[str]): + continue + + print_message(logger, f"RUN-TESTS: {phase_name}-time tests [{name}]", verbose) +- fn() ++ if not allow_failures: ++ fn() ++ continue ++ ++ # Failures are tolerated: a test callback that raises (for example because ++ # ``make test`` exited with a non-zero status) is recorded as a failure instead ++ # of aborting the installation. ++ try: ++ fn() ++ except spack.error.StopPhase: ++ raise ++ except Exception as e: ++ msg = f"RUN-TESTS: {phase_name}-time tests [{name}] failed" ++ print_message(logger, msg, verbose) ++ self.add_failure(e, msg) ++ if fail_fast: ++ break + + if have_tests: + print_message(logger, "Completed testing", verbose) + +- # Raise any collected failures here + if self.test_failures: +- raise TestFailure(self.test_failures) ++ if not allow_failures: ++ # Raise any collected failures here ++ raise TestFailure(self.test_failures) ++ # Always show this on the console, not only in the log file ++ with logger.force_echo(): ++ tty.warn( ++ f"Ignoring {phase_name}-time test failures for {builder.pkg.spec.name} " ++ f"(--allow-test-failures):\n{TestFailure(self.test_failures)}\n" ++ f"See test results at:\n {self.test_log_file}" ++ ) + + def stand_alone_tests(self, kwargs, timeout: Optional[int] = None) -> None: + """Run the package's stand-alone tests. +diff --git a/lib/spack/spack/installer.py b/lib/spack/spack/installer.py +index 692501d..72c5b51 100644 +--- a/lib/spack/spack/installer.py ++++ b/lib/spack/spack/installer.py +@@ -1252,6 +1252,7 @@ def start(self): + + tests = install_args.get("tests") + pkg.run_tests = tests is True or tests and pkg.name in tests ++ pkg.allow_test_failures = bool(install_args.get("allow_test_failures", False)) + + # Use the binary cache to install if requested, + # save result to be handled in BuildTask.complete() +@@ -1484,6 +1485,7 @@ def __init__( + stop_at: Optional[str] = None, + stop_before: Optional[str] = None, + tests: Union[bool, List[str], Set[str]] = False, ++ allow_test_failures: bool = False, + unsigned: Optional[bool] = None, + verbose: bool = False, + concurrent_packages: Optional[int] = None, +@@ -1552,6 +1554,7 @@ def __init__( + "stop_at": stop_at, + "stop_before": stop_before, + "tests": tests, ++ "allow_test_failures": allow_test_failures, + "unsigned": unsigned, + "verbose": verbose, + "concurrent_packages": self.concurrent_packages, +diff --git a/lib/spack/spack/installer_dispatch.py b/lib/spack/spack/installer_dispatch.py +index a70a5e4..27575be 100644 +--- a/lib/spack/spack/installer_dispatch.py ++++ b/lib/spack/spack/installer_dispatch.py +@@ -34,6 +34,7 @@ def create_installer( + stop_at: Optional[str] = None, + stop_before: Optional[str] = None, + tests: Union[bool, List[str], Set[str]] = False, ++ allow_test_failures: bool = False, + unsigned: Optional[bool] = None, + verbose: bool = False, + concurrent_packages: Optional[int] = None, +@@ -75,6 +76,7 @@ def create_installer( + stop_at=stop_at, + stop_before=stop_before, + tests=tests, ++ allow_test_failures=allow_test_failures, + unsigned=unsigned, + verbose=verbose, + concurrent_packages=concurrent_packages, +diff --git a/lib/spack/spack/new_installer.py b/lib/spack/spack/new_installer.py +index 3a82faa..09a7852 100644 +--- a/lib/spack/spack/new_installer.py ++++ b/lib/spack/spack/new_installer.py +@@ -252,6 +252,27 @@ def send_progress(current: int, total: int, state_pipe: io.TextIOWrapper) -> Non + state_pipe.write("\n") + + ++def send_warning(message: str, state_pipe: io.TextIOWrapper) -> None: ++ """Send a warning that the parent prints once the installation is over.""" ++ json.dump({"warning": message}, state_pipe, separators=(",", ":")) ++ state_pipe.write("\n") ++ ++ ++def send_ignored_test_failures(pkg: "spack.package_base.PackageBase", state_pipe) -> None: ++ """If test failures were tolerated (``--allow-test-failures``), warn the parent process.""" ++ if not (pkg.run_tests and pkg.allow_test_failures): ++ return ++ tester = pkg.tester ++ if not tester or not tester.test_failures: ++ return ++ num = len(tester.test_failures) ++ send_warning( ++ f"{pkg.spec.cformat('{name}{@version}')}: {num} test failure(s) ignored " ++ f"(--allow-test-failures). See test results at: {tester.test_log_file}", ++ state_pipe, ++ ) ++ ++ + def send_installed_from_binary_cache(state_pipe: io.TextIOWrapper) -> None: + """Send a notification that the package was installed from binary cache.""" + json.dump({"installed_from_binary_cache": True}, state_pipe, separators=(",", ":")) +@@ -388,6 +409,7 @@ def worker_function( + fake: bool, + install_source: bool, + run_tests: bool, ++ allow_test_failures: bool, + state: IpcChannel, + parent: IpcChannel, + tee_control_r: IpcChannel, +@@ -414,6 +436,7 @@ def worker_function( + keep_prefix: Whether to keep a failed installation prefix + skip_patch: Whether to skip the patch phase + run_tests: Whether to run install-time tests for this package ++ allow_test_failures: Whether failing install-time tests are reported as warnings + state: Connection to send state updates to + parent: Connection to send build output to + tee_control_r: Read end of the control pipe; the parent sends echo on/off here +@@ -511,6 +534,7 @@ def handle_sigterm(signum, frame): + run_tests, + stop_before, + stop_at, ++ allow_test_failures, + ) + except spack.error.StopPhase: + exit_code = ExitCode.STOPPED_AT_PHASE +@@ -682,12 +706,14 @@ def _install( + run_tests: bool = False, + stop_before: Optional[str] = None, + stop_at: Optional[str] = None, ++ allow_test_failures: bool = False, + ) -> None: + """Install a spec from build cache or source.""" + + # Create the stage and log file before starting the tee thread. + pkg = spec.package + pkg.run_tests = run_tests ++ pkg.allow_test_failures = allow_test_failures + + if fake: + store.layout.create_install_directory(spec) +@@ -791,6 +817,7 @@ def _install( + send_state(f"stopped after {stop_at}", state_stream) + raise spack.error.StopPhase(f"Stopping at '{stop_at}'") + ++ send_ignored_test_failures(pkg, state_stream) + _archive_build_metadata(pkg) + spack.hooks.post_install(spec, explicit) + +@@ -809,6 +836,7 @@ def start_build( + fake: bool, + install_source: bool, + run_tests: bool, ++ allow_test_failures: bool, + jobserver: JobServerBase, + log_path: str, + stop_before: Optional[str] = None, +@@ -852,6 +880,7 @@ def start_build( + fake, + install_source, + run_tests, ++ allow_test_failures, + state_w_conn, + output_w_conn, + control_r_conn, +@@ -2015,6 +2044,7 @@ def __init__( + stop_at: Optional[str] = None, + stop_before: Optional[str] = None, + tests: Union[bool, List[str], Set[str]] = False, ++ allow_test_failures: bool = False, + unsigned: Optional[bool] = None, + verbose: bool = False, + concurrent_packages: Optional[int] = None, +@@ -2028,6 +2058,7 @@ def __init__( + self.stop_at = stop_at + self.stop_before = stop_before + self.tests: Union[bool, List[str], Set[str]] = tests ++ self.allow_test_failures = allow_test_failures + + self.db = spack.store.STORE.db + +@@ -2049,6 +2080,8 @@ def __init__( + # sequence, so framing is safe without decoding partial reads. Keyed by PID rather than fd + # because on Windows the state channel is a socket whose handle is not a stable POSIX fd. + self.state_buffers: Dict[int, bytes] = {} ++ #: Warnings sent by build processes, printed once the installation is over ++ self.build_warnings: List[str] = [] + + if explicit is True: + self.explicit = {spec.dag_hash() for spec in specs} +@@ -2356,6 +2389,9 @@ def _installer(self) -> None: + if db_exc is not None: + raise db_exc + ++ for warning in self.build_warnings: ++ spack.llnl.util.tty.warn(warning) ++ + try: + self.report_data.finalize(self.reports, build_graph=self.build_graph) + except Exception as e: +@@ -2586,6 +2622,7 @@ def _start( + fake=self.fake, + install_source=self.install_source, + run_tests=run_tests, ++ allow_test_failures=self.allow_test_failures, + jobserver=jobserver, + log_path=self.log_paths[dag_hash], + stop_before=self.stop_before if is_root else None, +@@ -2684,6 +2721,8 @@ def _handle_child_state(self, child_info: ChildInfo, selector: selectors.BaseSel + ) + elif "installed_from_binary_cache" in message: + child_info.spec.package.installed_from_binary_cache = True ++ elif "warning" in message: ++ self.build_warnings.append(message["warning"]) + + return True + +diff --git a/lib/spack/spack/package_base.py b/lib/spack/spack/package_base.py +index cfa8ef7..a2d1c1b 100644 +--- a/lib/spack/spack/package_base.py ++++ b/lib/spack/spack/package_base.py +@@ -600,6 +600,10 @@ class PackageBase(WindowsRPath, PackageViewMixin, metaclass=PackageMeta): + #: By default do not run tests within package's install() + run_tests: bool = False + ++ #: If True, failures of install-time tests are reported as warnings instead of ++ #: failing the installation (set by ``spack install --allow-test-failures``) ++ allow_test_failures: bool = False ++ + #: Most packages are NOT extendable. Set to True if you want extensions. + extendable: bool = False + +diff --git a/lib/spack/spack/test/new_installer.py b/lib/spack/spack/test/new_installer.py +index 6064d0c..fc060b2 100644 +--- a/lib/spack/spack/test/new_installer.py ++++ b/lib/spack/spack/test/new_installer.py +@@ -756,3 +756,40 @@ def test_expand_build_deps_source_only_includes_nested_build_deps(temporary_stor + # nested_build_tool must also be added (BUILD dep of build_tool). This is the bug: without the + # fix, expand_build_deps only traverses LINK|RUN, so nested_build_tool is missing. + assert specs["nested_build_tool"].dag_hash() in added_hashes ++ ++ ++@pytest.mark.not_on_windows("POSIX pipes") ++@pytest.mark.parametrize("allow", [True, False]) ++def test_ignored_test_failures_reach_parent(allow): ++ """A build process reports tolerated test failures to the parent, which collects them.""" ++ from multiprocessing import Pipe ++ from types import SimpleNamespace ++ from unittest import mock ++ ++ from spack.new_installer import send_ignored_test_failures ++ from spack.new_installer_posix import make_state_stream ++ ++ pkg = mock.Mock(run_tests=True, allow_test_failures=allow) ++ pkg.spec.cformat.return_value = "fmt@12.2.0" ++ pkg.tester.test_failures = [(RuntimeError("boom"), "failed")] ++ pkg.tester.test_log_file = "/path/to/test-log.txt" ++ ++ state_r, state_w = Pipe(duplex=False) ++ stream = make_state_stream(state_w) ++ send_ignored_test_failures(pkg, stream) ++ stream.flush() ++ ++ installer = PackageInstaller.__new__(PackageInstaller) ++ installer.state_buffers = {} ++ installer.build_warnings = [] ++ child = SimpleNamespace(state_r_conn=state_r, proc=SimpleNamespace(pid=1), spec=mock.Mock()) ++ if allow: ++ installer._handle_child_state(child, mock.Mock()) ++ assert len(installer.build_warnings) == 1 ++ assert "fmt@12.2.0: 1 test failure(s) ignored" in installer.build_warnings[0] ++ assert "/path/to/test-log.txt" in installer.build_warnings[0] ++ else: ++ # nothing was written, so there is nothing to read ++ state_w.close() ++ installer._handle_child_state(child, mock.Mock()) ++ assert installer.build_warnings == [] +diff --git a/lib/spack/spack/test/test_suite.py b/lib/spack/spack/test/test_suite.py +index c876428..99fb5eb 100644 +--- a/lib/spack/spack/test/test_suite.py ++++ b/lib/spack/spack/test/test_suite.py +@@ -2,14 +2,17 @@ + # + # SPDX-License-Identifier: (Apache-2.0 OR MIT) + import collections ++import contextlib + import os + import pathlib + import sys ++from unittest import mock + + import pytest + + import spack.concretize + import spack.config ++import spack.error + import spack.install_test + import spack.spec + import spack.util.executable +@@ -524,3 +527,73 @@ def test_packagetest_fails(mock_packages): + pkg = MyPackage(s) + with pytest.raises(ValueError, match="require a concrete package"): + spack.install_test.PackageTest(pkg) ++ ++ ++def _phase_tester(monkeypatch): ++ """A PackageTest with just enough state to run ``phase_tests``.""" ++ tester = spack.install_test.PackageTest.__new__(spack.install_test.PackageTest) ++ tester.test_failures = [] ++ logger = mock.Mock() ++ logger.force_echo.side_effect = contextlib.nullcontext ++ monkeypatch.setattr( ++ tester, "test_logger", lambda **kwargs: contextlib.nullcontext(logger), raising=False ++ ) ++ tester.test_log_file = "/path/to/test-log.txt" ++ return tester ++ ++ ++def _phase_builder(callback, allow_test_failures): ++ builder = mock.Mock() ++ builder.pkg.allow_test_failures = allow_test_failures ++ builder.check = callback ++ return builder ++ ++ ++def _failing_check(): ++ raise spack.util.executable.ProcessError("Command exited with status 2: make test") ++ ++ ++@pytest.mark.parametrize("phase", ["build", "install"]) ++def test_phase_tests_failure_is_fatal_by_default(monkeypatch, phase): ++ """A test callback that raises aborts the installation unless failures are allowed.""" ++ tester = _phase_tester(monkeypatch) ++ builder = _phase_builder(_failing_check, allow_test_failures=False) ++ with pytest.raises(spack.util.executable.ProcessError): ++ tester.phase_tests(builder, phase, ["check"]) ++ ++ ++@pytest.mark.parametrize("phase", ["build", "install"]) ++def test_phase_tests_failure_allowed(monkeypatch, capfd, phase): ++ """With allow_test_failures, a raising test callback becomes a warning.""" ++ tester = _phase_tester(monkeypatch) ++ builder = _phase_builder(_failing_check, allow_test_failures=True) ++ tester.phase_tests(builder, phase, ["check"]) ++ assert len(tester.test_failures) == 1 ++ assert "make test" in str(tester.test_failures[0][0]) ++ err = capfd.readouterr().err ++ assert f"Ignoring {phase}-time test failures" in err ++ assert "/path/to/test-log.txt" in err ++ ++ ++def test_phase_tests_collected_failures_allowed(monkeypatch): ++ """Failures recorded via add_failure do not raise when allow_test_failures is set.""" ++ tester = _phase_tester(monkeypatch) ++ builder = _phase_builder(lambda: tester.add_failure(RuntimeError("boom"), "failed"), True) ++ tester.phase_tests(builder, "install", ["check"]) ++ assert len(tester.test_failures) == 1 ++ ++ tester = _phase_tester(monkeypatch) ++ builder = _phase_builder(lambda: tester.add_failure(RuntimeError("boom"), "failed"), False) ++ with pytest.raises(spack.install_test.TestFailure): ++ tester.phase_tests(builder, "install", ["check"]) ++ ++ ++def test_phase_tests_stop_phase_is_not_swallowed(monkeypatch): ++ tester = _phase_tester(monkeypatch) ++ ++ def stop(): ++ raise spack.error.StopPhase("stop") ++ ++ builder = _phase_builder(stop, allow_test_failures=True) ++ with pytest.raises(spack.error.StopPhase): ++ tester.phase_tests(builder, "build", ["check"]) +diff --git a/share/spack/spack-completion.bash b/share/spack/spack-completion.bash +index 2b0768b..51ed9c6 100644 +--- a/share/spack/spack-completion.bash ++++ b/share/spack/spack-completion.bash +@@ -1367,7 +1367,7 @@ _spack_info() { + _spack_install() { + if $list_options + then +- SPACK_COMPREPLY="-h --help --only -u --until -p --concurrent-packages -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --use-buildcache --include-build-deps --no-check-signature --show-log-on-error --source -n --no-checksum -v --verbose --fake --only-concrete --add --no-add --clean --dirty --test --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -f --force -U --fresh --reuse --fresh-roots --reuse-deps --deprecated" ++ SPACK_COMPREPLY="-h --help --only -u --until -p --concurrent-packages -j --jobs --overwrite --fail-fast --keep-prefix --keep-stage --dont-restage --use-cache --no-cache --cache-only --use-buildcache --include-build-deps --no-check-signature --show-log-on-error --source -n --no-checksum -v --verbose --fake --only-concrete --add --no-add --clean --dirty --test --allow-test-failures --log-format --log-file --help-cdash --cdash-upload-url --cdash-build --cdash-site --cdash-track --cdash-buildstamp -y --yes-to-all -f --force -U --fresh --reuse --fresh-roots --reuse-deps --deprecated" + else + _all_packages + fi +diff --git a/share/spack/spack-completion.fish b/share/spack/spack-completion.fish +index 3493121..01dba58 100644 +--- a/share/spack/spack-completion.fish ++++ b/share/spack/spack-completion.fish +@@ -2132,7 +2132,7 @@ complete -c spack -n '__fish_spack_using_command info' -l virtuals -d 'output vi + complete -c spack -n '__fish_spack_using_command info' -l variants-by-name -f -a by_name + + # spack install +-set -g __fish_spack_optspecs_spack_install h/help only= u/until= p/concurrent-packages= j/jobs= overwrite fail-fast keep-prefix keep-stage dont-restage use-cache no-cache cache-only use-buildcache= include-build-deps no-check-signature show-log-on-error source n/no-checksum v/verbose fake only-concrete add no-add clean dirty test= log-format= log-file= help-cdash cdash-upload-url= cdash-build= cdash-site= cdash-track= cdash-buildstamp= y/yes-to-all f/force U/fresh reuse fresh-roots deprecated ++set -g __fish_spack_optspecs_spack_install h/help only= u/until= p/concurrent-packages= j/jobs= overwrite fail-fast keep-prefix keep-stage dont-restage use-cache no-cache cache-only use-buildcache= include-build-deps no-check-signature show-log-on-error source n/no-checksum v/verbose fake only-concrete add no-add clean dirty test= allow-test-failures log-format= log-file= help-cdash cdash-upload-url= cdash-build= cdash-site= cdash-track= cdash-buildstamp= y/yes-to-all f/force U/fresh reuse fresh-roots deprecated + complete -c spack -n '__fish_spack_using_command_pos_remainder 0 install' -f -k -a '(__fish_spack_specs)' + complete -c spack -n '__fish_spack_using_command install' -s h -l help -f -a help + complete -c spack -n '__fish_spack_using_command install' -s h -l help -d 'show this help message and exit' +@@ -2188,6 +2188,8 @@ complete -c spack -n '__fish_spack_using_command install' -l dirty -f -a dirty + complete -c spack -n '__fish_spack_using_command install' -l dirty -d 'preserve user environment in spack'"'"'s build environment (danger!)' + complete -c spack -n '__fish_spack_using_command install' -l test -r -f -a 'root all' + complete -c spack -n '__fish_spack_using_command install' -l test -r -d 'run tests on only root packages or all packages' ++complete -c spack -n '__fish_spack_using_command install' -l allow-test-failures -f -a allow_test_failures ++complete -c spack -n '__fish_spack_using_command install' -l allow-test-failures -d 'with --test, report failing install-time tests as warnings instead of failing the installation' + complete -c spack -n '__fish_spack_using_command install' -l log-format -r -f -a 'junit cdash' + complete -c spack -n '__fish_spack_using_command install' -l log-format -r -d 'format to be used for log files' + complete -c spack -n '__fish_spack_using_command install' -l log-file -r -f -a log_file diff --git a/gysela.yaml b/gysela.yaml index 452c4c8..2c13d11 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -55,15 +55,15 @@ spack: - 'ddc' - 'fmt' - 'ginkgo' - # - 'gmgpolar', SerialDirectSolverTest_CircularGeometry.DirectSolverAcrossOriginHigherPrecision2_CircularGeometry tolerance failure + - 'gmgpolar' - 'gyselalibxx' - 'gysela-mini-app-io' - - 'hdf5 +mpi +shared' + - 'hdf5 +mpi +shared +subfiling' - 'kokkos' - 'kokkos-fft' - 'kokkos-tools' # - 'kokkos-kernels', some tests do not link without some ETI - # - 'kokkos-kernels +execspace_serial', serial.sparse_spmv_sell_double_int_size_t_TestDevice tolerance failure + - 'kokkos-kernels +execspace_serial' - 'koliop' # - 'mdspan', no releases - 'mdspan@stable' From 5f3639ac726e4194bf40da3b085bc3805e88b607 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 26 Oct 2026 18:09:07 +0100 Subject: [PATCH 38/40] Remove free-disk-space --- .github/workflows/spack.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index e80fbc6..c07406f 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -24,8 +24,6 @@ jobs: permissions: packages: write # Required to push to registry steps: - - name: Free Disk Space (Ubuntu) - uses: jlumbroso/free-disk-space@ceedf095f4ec1a097402bc6bd80831f2e1a6fde6 # v2.0.0 - name: Checkout built branch uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 - name: Set up Spack From 3b104c38a3b4c091d9474690303bff5afae0ae9d Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Mon, 26 Oct 2026 20:00:02 +0100 Subject: [PATCH 39/40] Prefer GCC 16 --- .github/workflows/spack.yaml | 4 ++++ gysela.yaml | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/spack.yaml b/.github/workflows/spack.yaml index c07406f..bd59bec 100644 --- a/.github/workflows/spack.yaml +++ b/.github/workflows/spack.yaml @@ -24,6 +24,10 @@ jobs: permissions: packages: write # Required to push to registry steps: + - run: | + export DEBIAN_FRONTEND=noninteractive + sudo apt-get update + sudo apt-get install --assume-yes --no-install-recommends gcc-16 g++-16 gfortran-16 - name: Checkout built branch uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 - name: Set up Spack diff --git a/gysela.yaml b/gysela.yaml index 2c13d11..013a64a 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -31,11 +31,11 @@ spack: - '~mpi' - '~fortran' c: - require: 'gcc@15.2' + require: 'gcc@16' cxx: - require: 'gcc@15.2' + require: 'gcc@16' fortran: - require: 'gcc@15.2' + require: 'gcc@16' py-dask: prefer: - '~dataframe' From 29f423d3a378b4a53248b79fa910d1d490667354 Mon Sep 17 00:00:00 2001 From: Thomas Padioleau Date: Sat, 14 Nov 2026 12:08:41 +0100 Subject: [PATCH 40/40] Update --- gysela.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gysela.yaml b/gysela.yaml index 013a64a..b1437a2 100644 --- a/gysela.yaml +++ b/gysela.yaml @@ -65,8 +65,7 @@ spack: # - 'kokkos-kernels', some tests do not link without some ETI - 'kokkos-kernels +execspace_serial' - 'koliop' - # - 'mdspan', no releases - - 'mdspan@stable' + - 'mdspan' - 'netcdf-c' - 'openblas' - 'paraconf' @@ -79,7 +78,6 @@ spack: - 'pdiplugin-set-value' - 'pdiplugin-trace' - 'pdiplugin-user-code' - # - 'py-numpy', error: ModuleNotFoundError: No module named 'numpy' - 'spdlog' view: default: