From 11ba5d80847594697c0e55e7af1ea6d2adddd412 Mon Sep 17 00:00:00 2001 From: Jake Howard Date: Mon, 29 Sep 2025 16:58:51 +0100 Subject: [PATCH 1/3] Clean up startup wording --- buckup/command_line.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/buckup/command_line.py b/buckup/command_line.py index 6f5a961..1dfe062 100644 --- a/buckup/command_line.py +++ b/buckup/command_line.py @@ -52,7 +52,8 @@ def print_welcome_information(self): | | |_| """) - print("Queries: http://github.com/torchbox/buckup\n") + print("Version:", __version__) + print("Issues: http://github.com/torchbox/buckup\n") print( "We are going to create an S3 bucket with a user that is ready " "to use. In the end\nyou will have a bucket name, access key " @@ -103,7 +104,6 @@ def print_account_information(self): if not region: print('You need to specify region with "--region".') sys.exit(1) - print('Use "--profile" flag to use a different boto3 profile.') print( "Region used is {region}. " 'Use "--region" to specify a different ' From 2a4617fd7fc1ad2a8028e75f274a37fe7192e009 Mon Sep 17 00:00:00 2001 From: Jake Howard Date: Mon, 29 Sep 2025 16:59:11 +0100 Subject: [PATCH 2/3] Add warning about sensitive values before creating bucket --- buckup/command_line.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/buckup/command_line.py b/buckup/command_line.py index 1dfe062..3c4a135 100644 --- a/buckup/command_line.py +++ b/buckup/command_line.py @@ -240,6 +240,11 @@ def execute(self): self.ask_cors() self.print_separator() if self.ask_summary(): + self.print_separator() + print( + "Warning: The following information contains sensitive values. " + "Be careful when copying and pasting." + ) self.print_separator() self.create_bucket() From c2e81c31e5cf2b0a277820a5beabcaf5d8e723d3 Mon Sep 17 00:00:00 2001 From: Jake Howard Date: Mon, 29 Sep 2025 16:59:31 +0100 Subject: [PATCH 3/3] Use env file syntax for environment variables This makes them easier to copy --- buckup/bucket_creator.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/buckup/bucket_creator.py b/buckup/bucket_creator.py index e382925..fd85568 100644 --- a/buckup/bucket_creator.py +++ b/buckup/bucket_creator.py @@ -185,7 +185,7 @@ def create_bucket(self, name, region): ) ) print() - print("\tAWS_STORAGE_BUCKET_NAME", name) + print(f"AWS_STORAGE_BUCKET_NAME='{name}'") print() bucket.wait_until_exists() return bucket @@ -210,8 +210,8 @@ def create_user_access_key_pair(self, user): ) ) print() - print("\tAWS_ACCESS_KEY_ID", access_key_pair.access_key_id) - print("\tAWS_SECRET_ACCESS_KEY", access_key_pair.secret_access_key) + print(f"AWS_ACCESS_KEY_ID='{access_key_pair.access_key_id}'") + print(f"AWS_SECRET_ACCESS_KEY='{access_key_pair.secret_access_key}'") print() return access_key_pair