Add custom platforms (#132)

Author: tinysec

Function/BNCreateCustomPlatform.cs

@@ -17,15 +17,9 @@ internal static partial class NativeMethods
             EntryPoint = "BNCreateCustomPlatform"
         )]
 		internal static extern IntPtr BNCreateCustomPlatform(
-			
-			// BNArchitecture* arch
-		    IntPtr arch  , 
-			
-			// const char* name
-		    [MarshalAs(UnmanagedType.LPUTF8Str)] string name  , 
-			
-			// BNCustomPlatform* impl
-		    IntPtr impl  
+			IntPtr arch,
+			[MarshalAs(UnmanagedType.LPUTF8Str)] string name,
+			in BNCustomPlatform implementation
 		);
 	}
-}
+}

Function/BNCreateCustomPlatformWithTypes.cs

@@ -17,24 +17,12 @@ internal static partial class NativeMethods
             EntryPoint = "BNCreateCustomPlatformWithTypes"
         )]
 		internal static extern IntPtr BNCreateCustomPlatformWithTypes(
-			
-			// BNArchitecture* arch
-		    IntPtr arch  , 
-			
-			// const char* name
-		    [MarshalAs(UnmanagedType.LPUTF8Str)] string name  , 
-			
-			// BNCustomPlatform* impl
-		    IntPtr impl  , 
-			
-			// const char* typeFile
-		    [MarshalAs(UnmanagedType.LPUTF8Str)] string typeFile  , 
-			
-			// const char** includeDirs
-		    string[] includeDirs  , 
-			
-			// uint64_t includeDirCount
-		    ulong includeDirCount  
+			IntPtr arch,
+			[MarshalAs(UnmanagedType.LPUTF8Str)] string name,
+			in BNCustomPlatform implementation,
+			[MarshalAs(UnmanagedType.LPUTF8Str)] string typeFile,
+			IntPtr includeDirs,
+			ulong includeDirCount
 		);
 	}
-}
+}

Handle/BNPlatform.cs

@@ -5,12 +5,27 @@
 
 namespace BinaryNinja
 {
-	public sealed class Platform :  AbstractSafeHandle<Platform>
+	public partial class Platform : AbstractSafeHandle<Platform>
 	{
 		public Platform(Architecture arch , string name)
-			:this( NativeMethods.BNCreatePlatform(arch.DangerousGetHandle() , name) , true)
+			: base(true)
 		{
-			
+			this.custom = true;
+			this.InitializeCustomPlatform(arch, name, null, Array.Empty<string>());
+		}
+
+		protected Platform(
+			Architecture arch,
+			string name,
+			string typeFile,
+			string[] includeDirs
+		)
+			: base(true)
+		{
+			this.custom = true;
+			this.InitializeCustomPlatform(
+				arch, name, typeFile, includeDirs ?? Array.Empty<string>()
+			);
 		}
 
 	    internal Platform(IntPtr handle , bool owner) 
@@ -87,7 +102,7 @@ internal static Platform MustBorrowHandle(IntPtr handle)
 
 	    protected override bool ReleaseHandle()
 	    {
-	        if ( !this.IsInvalid )
+	        if (!this.IsInvalid && !this.registered)
 	        {
 	            NativeMethods.BNFreePlatform(this.handle);
 	            this.SetHandleAsInvalid();
@@ -144,6 +159,7 @@ public static string[] GetOSList()
 	    public void RegisterPlatform(string os)
 	    {
 		    NativeMethods.BNRegisterPlatform(os , this.handle);
+		    Platform.RootForRegistration(this);
 	    }
 
 	    public string Name
@@ -280,10 +296,15 @@ public void SetSystemCallConvention(BinaryNinja.CallingConvention callConvention
 		    );
 	    }
 
-	    public uint[] GlobalRegisters
+	    public virtual uint[] GlobalRegisters
 	    {
 		    get
 		    {
+			    if (this.custom)
+			    {
+				    return this.GetDefaultGlobalRegisters();
+			    }
+
 			    IntPtr arrayPointer = NativeMethods.BNGetPlatformGlobalRegisters(
 				    this.handle,
 				    out ulong arrayLength
@@ -297,10 +318,15 @@ out ulong arrayLength
 		    }
 	    }
 
-	    public ulong AddressSize
+	    public virtual ulong AddressSize
 	    {
 		    get
 		    {
+			    if (this.custom)
+			    {
+				    return this.Architecture.AddressSize;
+			    }
+
 			    return NativeMethods.BNGetPlatformAddressSize(this.handle);
 		    }
 	    }
@@ -551,8 +577,13 @@ public static unsafe Platform[] GetListByOSAndArchitecture(string os, Architectu
 	    /// <summary>
 	    /// Gets the type of a global register on this platform.
 	    /// </summary>
-	    public BinaryNinja.Type? GetGlobalRegisterType(uint reg)
+	    public virtual BinaryNinja.Type? GetGlobalRegisterType(uint reg)
 	    {
+		    if (this.custom)
+		    {
+			    return null;
+		    }
+
 		    return BinaryNinja.Type.TakeHandle(
 			    NativeMethods.BNGetPlatformGlobalRegisterType(this.handle , reg)
 		    );
@@ -836,4 +867,4 @@ string[] includeDirs
 	    }
 	}
 
-}
+}