feat: complete MLIL helper builders

Author: tinysec

Handle/BNMediumLevelILFunction.cs

@@ -1932,12 +1932,7 @@ public MediumLevelILExpressionIndex EmitFloatConst(
 		    SourceLocation? location = null
 	    )
 	    {
-		    return this.AddExpression(
-			    MediumLevelILOperation.MLIL_FLOAT_CONST,
-			    location,
-			    size,
-			    value
-		    );
+		    return this.EmitFloatConstRaw(size, value, location);
 	    }
 
 	    public MediumLevelILExpressionIndex EmitImport(

MediumLevelIL/MLILFloatConst.cs

@@ -17,9 +17,17 @@ public double Constant
 		{
 			get
 			{
-				return BitConverter.UInt64BitsToDouble(
-					this.RawOperands[0]
-				);
+				if (4 == this.Size)
+				{
+					return this.GetOperandAsFloat(0);
+				}
+
+				if (8 == this.Size)
+				{
+					return this.GetOperandAsDouble(0);
+				}
+
+				return this.RawOperands[0];
 			}
 		}
 	}

MediumLevelIL/MediumLevelILHelperBuilders.cs

@@ -0,0 +1,86 @@
+using System;
+
+namespace BinaryNinja
+{
+	public sealed partial class MediumLevelILFunction
+	{
+		/// <summary>
+		/// Creates a floating-point constant from its raw binary representation.
+		/// </summary>
+		public MediumLevelILExpressionIndex EmitFloatConstRaw(
+			ulong size,
+			ulong value,
+			SourceLocation? location = null)
+		{
+			return this.AddExpression(
+				MediumLevelILOperation.MLIL_FLOAT_CONST,
+				location,
+				size,
+				value);
+		}
+
+		/// <summary>
+		/// Creates a single-precision floating-point constant.
+		/// </summary>
+		public MediumLevelILExpressionIndex EmitFloatConstSingle(
+			float value,
+			SourceLocation? location = null)
+		{
+			uint bits = BitConverter.SingleToUInt32Bits(value);
+
+			return this.EmitFloatConstRaw(4, bits, location);
+		}
+
+		/// <summary>
+		/// Creates a double-precision floating-point constant.
+		/// </summary>
+		public MediumLevelILExpressionIndex EmitFloatConstDouble(
+			double value,
+			SourceLocation? location = null)
+		{
+			ulong bits = BitConverter.DoubleToUInt64Bits(value);
+
+			return this.EmitFloatConstRaw(8, bits, location);
+		}
+
+		/// <summary>
+		/// Creates a helper expression holding a separately allocated parameter list.
+		/// </summary>
+		public MediumLevelILExpressionIndex EmitSeparateParamList(
+			MediumLevelILExpressionIndex[] parameters,
+			SourceLocation? location = null)
+		{
+			if (null == parameters)
+			{
+				throw new ArgumentNullException(nameof(parameters));
+			}
+
+			return this.AddExpression(
+				MediumLevelILOperation.MLIL_SEPARATE_PARAM_LIST,
+				location,
+				0,
+				(ulong)parameters.Length,
+				(ulong)this.AddOperandList(parameters));
+		}
+
+		/// <summary>
+		/// Creates a helper expression holding parameters that share a parameter slot.
+		/// </summary>
+		public MediumLevelILExpressionIndex EmitSharedParamSlot(
+			MediumLevelILExpressionIndex[] parameters,
+			SourceLocation? location = null)
+		{
+			if (null == parameters)
+			{
+				throw new ArgumentNullException(nameof(parameters));
+			}
+
+			return this.AddExpression(
+				MediumLevelILOperation.MLIL_SHARED_PARAM_SLOT,
+				location,
+				0,
+				(ulong)parameters.Length,
+				(ulong)this.AddOperandList(parameters));
+		}
+	}
+}

Struct/BNMediumLevelILInstruction.cs

@@ -1376,7 +1376,17 @@ public virtual IList<ILOperand> DetailedOperands
 					return this.GetOperandAsSSAVariableList(index);
 
 				case ILOperandKind.Float:
-					return this.GetOperandAsDouble(index);
+					if (4 == this.Size)
+					{
+						return (double)this.GetOperandAsFloat(index);
+					}
+
+					if (8 == this.Size)
+					{
+						return this.GetOperandAsDouble(index);
+					}
+
+					return (double)this.RawOperands[(ulong)index];
 
 				case ILOperandKind.ConstantData:
 					return this.GetOperandAsConstantData(index, secondaryIndex);