Latest master cannot build with mvn

[wancer]

Hello!
I'm new with java.
Did all according to instruction https://github.com/timolson/cointrader/wiki/Setup
When try to build with maven get next error:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/MovStrategy.java:[30,34] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/BaseVolatilityStrategy.java:[63,54] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/PairsStrategy.java:[52,36] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/RunsStrategy.java:[36,35] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/MarketMakerStrategy.java:[48,42] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/MockTicker.java:[14,11] package jep does not exist
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/CorrelationStrategy.java:[30,42] cannot find symbol
  symbol: class TestStrategy
[ERROR] /D:/tmp/cointrader/src/main/java/org/cryptocoinpartners/module/ProbabilityTrendStrategy.java:[52,47] cannot find symbol
  symbol: class TestStrategy
[INFO] 8 errors

Tried on Windows & Ubuntu machines with jdk1.8 and 1.7, x86 and x64 - same problem.
Tried mvn clean and then mvn too

[NarimanAB]

it looks like TestStrategy was not included in the git... where can we get it?

[douggie]

strange, let me take a look

…

On Fri, Jul 21, 2017 at 10:58 PM, NarimanAB ***@***.***> wrote: it looks like TestStrategy was not included in the git... where can we get it? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHao3UsX7DeyEmlG4LCcf8Ek0DThX0ks5sQR8PgaJpZM4N4sUV> .

[douggie]

fixed checked in. On Fri, Jul 21, 2017 at 11:05 PM, Douggie melville-clarke < douggie@melvilleclarke.com> wrote:

…

strange, let me take a look On Fri, Jul 21, 2017 at 10:58 PM, NarimanAB ***@***.***> wrote: > it looks like TestStrategy was not included in the git... where can we > get it? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#141 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AENHao3UsX7DeyEmlG4LCcf8Ek0DThX0ks5sQR8PgaJpZM4N4sUV> > . >

[NarimanAB]

ok. but now it is different
cointrader/src/main/java/org/cryptocoinpartners/module/MockTicker.java:[14,11] package jep does not exist

[douggie]

strange, I see jep in the POM: <dependency> <groupId>org.python.pypi</groupId> <artifactId>jep</artifactId> <version>3.6.1</version> </dependency>

…

On Fri, Jul 21, 2017 at 11:33 PM, NarimanAB ***@***.***> wrote: ok. but now it is different cointrader/src/main/java/org/cryptocoinpartners/module/MockTicker.java:[14,11] package jep does not exist — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHavo-1wEQYALEFFqXcKCZT5mWzDSiks5sQScvgaJpZM4N4sUV> .

[douggie]

may be try down voteaccepted mvn clean install -U On Fri, Jul 21, 2017 at 11:53 PM, Douggie melville-clarke < douggie@melvilleclarke.com> wrote:

…

strange, I see jep in the POM: <dependency> <groupId>org.python.pypi</groupId> <artifactId>jep</artifactId> <version>3.6.1</version> </dependency> On Fri, Jul 21, 2017 at 11:33 PM, NarimanAB ***@***.***> wrote: > ok. but now it is different > cointrader/src/main/java/org/cryptocoinpartners/module/MockTicker.java:[14,11] > package jep does not exist > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#141 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AENHavo-1wEQYALEFFqXcKCZT5mWzDSiks5sQScvgaJpZM4N4sUV> > . >

[NarimanAB]

jep jar downloaded by maven contains java files (source code) but not compiled class files.

[douggie]

hum, strange, have not built from source for a while. let me take a look tonight, about 12 hours and sort it out. My apologies. Douggie

…

On Sat, Jul 22, 2017 at 9:34 AM, NarimanAB ***@***.***> wrote: jep jar downloaded by maven contains java files (source code) but not compiled class files. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHal083OJJt87jiJQOUwQn1KjNRHreks5sQbQXgaJpZM4N4sUV> .

[NarimanAB]

ok.
cointrader/repo/org/python/pypi/jep/3.6.1/jep-3.6.1.jar contains source files and not class files
As of my understanding, org/python/pypi/jep package requires native libraries for proper operation
However, in the local mavev "repo" there is only native library for macos for python version 2.7, what about Linux or other python versions? Project org/python/pypi/jep does not support installation via maven. org/python/pypi/jep declined proposal to support an installation via maven as there are too many native dependencies. Maybe, it is better to follow the 'official' way of library installation?

or to remove dependency on Python at all...

[douggie]

Hi, there is a complied version in /repo/org/python/pypi/jep/3.6.1. Should just be able to add this to your local repo. mvn install:install-file -Dfile= epo/org/python/pypi/jep/3.6.1/jep-3.6.1.jar -DgroupId=org.python.pypi -DartifactId=jep -Dversion=3.6.1 -Dpackaging=ja

…

On Sun, Jul 23, 2017 at 1:41 PM, NarimanAB ***@***.***> wrote: ok. cointrader/repo/org/python/pypi/jep/3.6.1/jep-3.6.1.jar contains source files and not class files As of my understanding, org/python/pypi/jep package requires native libraries for proper operation However, in the local mavev "repo" there is only native library for macos for python version 2.7, what about Linux or other python versions? Project org/python/pypi/jep does not support installation via maven. org/python/pypi/jep declined proposal to support of installation via maven as there are too many native dependencies. Maybe, it is better to follow 'official' way of library installation? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHatWwy2iWzqbt_l9T946e_AAaipdnks5sQz-DgaJpZM4N4sUV> .

[LeonidShamis]

Here is how I solved JEP issues (on Windows):

• installed JEP using pip: pip install jep (NOTE: I used the latest available version 3.6.4 - https://pypi.python.org/pypi/jep)
• created repo\org\python\pypi\jep\3.6.4
• copied JAR from Python site-packages (...Python36\Lib\site-packages\jep\jep-3.6.4.jar) to this directory
• created repo\org\python\pypi\jep\3.6.4\jep-3.6.4.pom based on repo\org\python\pypi\jep\3.6.1\jep-3.6.1.pom - just replaced 3.6.1 with 3.6.4
• changed dependency in main pom.xml:

		<dependency>
			<groupId>org.python.pypi</groupId>
			<artifactId>jep</artifactId>
			<version>3.6.4</version>
		</dependency>

I believe the same could have been done with original version 3.6.1.

Hope that helps.

[LeonidShamis]

BTW, I still couldn't find TestStrategy anywhere, so I temporarily remove the following from src\main\java\org\cryptocoinpartners\module to pass maven build without error:

BaseMomentumStrategy.java
BaseVolatilityStrategy.java
CarryStrategy.java
CorrelationStrategy.java
MarketMakerStrategy.java
MomentumStrategy.java
MovStrategy.java
PairsStrategy.java
ProbabilityTrendStrategy.java
RunsStrategy.java

@douggie Where can I find checked in TestStrategy ?

[douggie]

Hi, Teststategy has been removed from repo, it was just a test that is not required. if you do a pull you should see it has gone. Thanks so much for the jep info. will add it to the wiki.

…

On Tue, Jul 25, 2017 at 11:27 AM, Leonid Shamis ***@***.***> wrote: BTW, I still couldn't find TestStrategy anywhere, so I temporarily remove the following from src\main\java\org\cryptocoinpartners\module to pass maven build without error: BaseMomentumStrategy.java BaseVolatilityStrategy.java CarryStrategy.java CorrelationStrategy.java MarketMakerStrategy.java MomentumStrategy.java MovStrategy.java PairsStrategy.java ProbabilityTrendStrategy.java RunsStrategy.java @douggie <https://github.com/douggie> Where can I find checked in TestStrategy ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHaqOWSPm21y8FF7LMikI44j42ZSExks5sRcMHgaJpZM4N4sUV> .

[Procyon112]

It does not appear that /src/main/java/org/cryptocoinpartners/module/TestStrategy.java was ever in the repo. It looks like it's on your machine and you didn't do a git add on it.

It's the abstract base class for all of the strategy modules. Can't build without it. Can you add it to the repo, please?

[douggie]

if you pull it is no longer in repo.

…

On Sat, Jul 29, 2017 at 6:49 AM, Procyon112 ***@***.***> wrote: It does not appear that /src/main/java/org/cryptocoinpartners/module/TestStrategy.java was ever in the repo. It looks like it's on your machine and you didn't do a git add on it. It's the abstract base class for all of the strategy modules. Can't build without it. Can you add it to the repo, please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AENHaqa9qTauPyNmmZNXMJArJEDxkvjbks5sSsfYgaJpZM4N4sUV> .