The security hardening PR for non-sensitive findings added/updated Solidity coverage for:
- Finding 12: allowlist weights deployment should fail if ownership transfer fails.
- Finding 13:
WalletRegistryGovernance.finalizeAuthorizationDecreaseDelayUpdate should preserve the authorization decrease change period.
During local validation, npx hardhat compile succeeds, but a focused Hardhat test run for WalletRegistryGovernance does not reach the test cases because the hardhat-deploy fixture fails before test execution:
ERROR processing deploy/00_resolve_reimbursement_pool.ts:
Error: deployed ReimbursementPool contract not found
This blocks end-to-end runtime validation for the governance/deployment portions of the PR even though compile and formatting checks pass.
Suggested follow-up:
- Repair or document the local fixture setup needed for
WalletRegistryGovernance.test.ts.
- Ensure the dependency deployment record for
ReimbursementPool is available in the test fixture path.
- Add a short validation note to the testing docs or package README so future reviewers can run focused Hardhat tests without rediscovering the setup gap.
The security hardening PR for non-sensitive findings added/updated Solidity coverage for:
WalletRegistryGovernance.finalizeAuthorizationDecreaseDelayUpdateshould preserve the authorization decrease change period.During local validation,
npx hardhat compilesucceeds, but a focused Hardhat test run forWalletRegistryGovernancedoes not reach the test cases because thehardhat-deployfixture fails before test execution:This blocks end-to-end runtime validation for the governance/deployment portions of the PR even though compile and formatting checks pass.
Suggested follow-up:
WalletRegistryGovernance.test.ts.ReimbursementPoolis available in the test fixture path.