From 69d087f862bf63d26630bc3acd13bb036f8b9d6f Mon Sep 17 00:00:00 2001 From: S Sakthivel Murugan Date: Thu, 24 Sep 2026 13:52:37 +0530 Subject: [PATCH 1/2] fix: use frappe.log_error instead of frappe.error_log --- hrms/overrides/company.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hrms/overrides/company.py b/hrms/overrides/company.py index 1202bb105c2..1e4a967e3fb 100644 --- a/hrms/overrides/company.py +++ b/hrms/overrides/company.py @@ -84,7 +84,7 @@ def make_salary_components(country): doc.flags.ignore_mandatory = True doc.insert(ignore_if_duplicate=True) except Exception as e: - frappe.error_log("Error occurred while creating Salary Component", e) + frappe.log_error("Error occurred while creating Salary Component", e) finally: frappe.clear_messages() From bcc7e6ebd19c75382021343d310da4d2f5cc7d8a Mon Sep 17 00:00:00 2001 From: nareshkannasln Date: Thu, 24 Sep 2026 18:07:28 +0530 Subject: [PATCH 2/2] chore: remove exception argument to log the full traceback --- hrms/overrides/company.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hrms/overrides/company.py b/hrms/overrides/company.py index 1e4a967e3fb..68396312afe 100644 --- a/hrms/overrides/company.py +++ b/hrms/overrides/company.py @@ -83,8 +83,8 @@ def make_salary_components(country): doc.flags.ignore_permissions = True doc.flags.ignore_mandatory = True doc.insert(ignore_if_duplicate=True) - except Exception as e: - frappe.log_error("Error occurred while creating Salary Component", e) + except Exception: + frappe.log_error("Error occurred while creating Salary Component") finally: frappe.clear_messages()