From 79049d3378f819927c07934270ea2f996c82ae3c Mon Sep 17 00:00:00 2001 From: Bicheng <31808103+BichengWang@users.noreply.github.com> Date: Tue, 8 Nov 2022 20:44:34 -0800 Subject: [PATCH 1/2] [Bug fix][Recommenders] fix variable miss Bug: Multi-task recommenders embedding_dimension variable defined inner class but refer before definition. Fix: reclaim variable embedding_dimension as 32 --- docs/examples/multitask.ipynb | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/examples/multitask.ipynb b/docs/examples/multitask.ipynb index 179a2355..acfb92e0 100644 --- a/docs/examples/multitask.ipynb +++ b/docs/examples/multitask.ipynb @@ -213,6 +213,7 @@ "The user and movie models are as before:\n", "\n", "```python\n", + "embedding_dimension=32 # define the default embedding dimension\n", "user_model = tf.keras.Sequential([\n", " tf.keras.layers.StringLookup(\n", " vocabulary=unique_user_ids, mask_token=None),\n", From ab5f91cc74798fdf09c19d3ef5de15ca1841d55b Mon Sep 17 00:00:00 2001 From: Bicheng <31808103+BichengWang@users.noreply.github.com> Date: Tue, 8 Nov 2022 20:49:13 -0800 Subject: [PATCH 2/2] Update multitask.ipynb --- docs/examples/multitask.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/multitask.ipynb b/docs/examples/multitask.ipynb index acfb92e0..a31535a1 100644 --- a/docs/examples/multitask.ipynb +++ b/docs/examples/multitask.ipynb @@ -213,7 +213,7 @@ "The user and movie models are as before:\n", "\n", "```python\n", - "embedding_dimension=32 # define the default embedding dimension\n", + "embedding_dimension=32\n", "user_model = tf.keras.Sequential([\n", " tf.keras.layers.StringLookup(\n", " vocabulary=unique_user_ids, mask_token=None),\n",