ReadMe.md: add code snippets#12
Open
knocte wants to merge 15 commits into
Open
Conversation
To be consistent.
The `class Foo` was missing from two.
By having a second Bar class, and negative test (prints false).
* Consistency across raw TS and Effect snippets wrt helper func. * Reduce DRY via str, n, foo vars. * Use camelCase for params, as it's generally the case for TS.
So that user really sees the real indentation magnification for Effect.ts' Option.match.
In Effect snippet, to be consistent with other snippets.
For consistency again.
And respect DRY.
Contributor
Author
|
TODO: research
|
knocte
commented
May 18, 2026
| // prints true | ||
| console.log(TypeHelpers.isInstanceOf(foo, Foo)); | ||
| // prints false | ||
| console.log(TypeHelpers.isInstanceOf(foo, Bar)); |
Contributor
Author
There was a problem hiding this comment.
@knocte maybe we should change this to Is.of(foo, Bar).isSome and make the value have the casted value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.