Use (item, rule) argument order in databases.delete_table_default_permissions

Every other permissions method takes the item first and the rule second,
but delete_table_default_permissions took (rule, item). Switch to
(item, rule). Callers using the old order keep working: swapped argument
types are detected, swapped back, and a DeprecationWarning pointing at
the caller is emitted.

Refs #735

Co-Authored-By: Claude Code <noreply@anthropic.com>

Author: jacalata

tableauserverclient/server/endpoint/databases_endpoint.py

@@ -1,4 +1,5 @@
 import logging
+import warnings
 from typing import TYPE_CHECKING
 from collections.abc import Iterable
 
@@ -193,7 +194,32 @@ def update_table_default_permissions(
         return self._default_permissions.update_default_permissions(item, rules, Resource.Table)
 
     @api(version="3.5")
-    def delete_table_default_permissions(self, rule: PermissionsRule, item: DatabaseItem) -> None:
+    def delete_table_default_permissions(self, item: DatabaseItem, rule: PermissionsRule) -> None:
+        """
+        Deletes the specified default table permission rule from the database.
+
+        REST API: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_permissions.htm#delete_default_permission
+
+        Parameters
+        ----------
+        item : DatabaseItem
+            The database item to delete default table permissions from.
+
+        rule : PermissionsRule
+            The permissions rule to delete from the database.
+
+        Returns
+        -------
+        None
+        """
+        if isinstance(item, PermissionsRule) and isinstance(rule, DatabaseItem):
+            warnings.warn(
+                "delete_table_default_permissions(rule, item) is deprecated; pass (item, rule) like the other "
+                "permissions methods.",
+                DeprecationWarning,
+                stacklevel=3,
+            )
+            item, rule = rule, item
         self._default_permissions.delete_default_permission(item, rule, Resource.Table)
 
     @api(version="3.5")

test/test_database.py

@@ -1,3 +1,4 @@
+import warnings
 from pathlib import Path
 
 import pytest
@@ -117,3 +118,35 @@ def test_populate_tables_not_supported(server):
     database._id = "23591f2c-4802-4d6a-9e28-574a8ea9bc4c"
     with pytest.raises(NotImplementedError, match="Metadata API"):
         server.databases.populate_tables(database)
+
+
+def _delete_table_default_permission_setup(server, m):
+    database = TSC.DatabaseItem("test")
+    database._id = "0448d2ed-590d-4fa0-b272-a2a8a24555b5"
+    rule = TSC.PermissionsRule(
+        grantee=TSC.GroupItem.as_reference("5e5e1978-71fa-11e4-87dd-7382f5c437af"),
+        capabilities={TSC.Permission.Capability.Read: TSC.Permission.Mode.Allow},
+    )
+    url = (
+        f"{server.databases.baseurl}/{database.id}/default-permissions/tables/groups/"
+        "5e5e1978-71fa-11e4-87dd-7382f5c437af/Read/Allow"
+    )
+    m.delete(url, status_code=204)
+    return database, rule
+
+
+def test_delete_table_default_permissions(server):
+    with requests_mock.mock() as m, warnings.catch_warnings():
+        warnings.simplefilter("error")
+        database, rule = _delete_table_default_permission_setup(server, m)
+        server.databases.delete_table_default_permissions(database, rule)
+        assert m.call_count == 1
+
+
+def test_delete_table_default_permissions_swapped_arguments_warns(server):
+    with requests_mock.mock() as m:
+        database, rule = _delete_table_default_permission_setup(server, m)
+        with pytest.warns(DeprecationWarning, match="deprecated") as record:
+            server.databases.delete_table_default_permissions(rule, database)
+        assert m.call_count == 1
+    assert record[0].filename == __file__